Comments (10)
Ok! I will work on that. I will start by writing tests for GamepadController class (mocking gamepad API) . We need tests for react components that were modified too ?
from jsnes-web.
Awesome thank you! Testing the integration of the modal with the controllers is probably a good idea (I donβt think there is any testing for the custom keyboard commands) but a test for the gamepadcontroller would also be useful. :)
from jsnes-web.
I can't see tests on current version of jsnes-web
So, I will follow this guide https://facebook.github.io/create-react-app/docs/running-tests to start adding the tests. It is ok ? (sorry, I am newbie on react)
from jsnes-web.
No worries! There are a couple really simple ones - the files ending in .test.js
in src/
.
from jsnes-web.
Great, I will follow the actual scheme then
from jsnes-web.
@tario Seems like the gamepad support is breaking non-webkit browsers too. This error is coming from IE: https://sentry.io/share/issue/b0c3a6b734294b30b6414c548d57a410/
from jsnes-web.
I am sorry to hear that, maybe I should fix that in a separated pull-request. What platforms we should cover ? IE? edge too?
from jsnes-web.
Just tested jsnes.org on edge and IE11 and the gamepad seems to be broken at all. Also tested on https://html5gamepad.com/ and again the gamepad doesn't seems to work at all. Gamepad API should be working on these browsers ?
from jsnes-web.
Anyway. I will fix the case where both getGamepads and webkitGetGamepads are not present. I think I have to code more defensively, sorry
from jsnes-web.
Here it is #167
from jsnes-web.
Related Issues (20)
- Is there a way to access the game data? HOT 1
- Where to put the roms ? HOT 3
- Support for more mappers.
- Add homebrew ROMs HOT 7
- Soud
- Refactor customizable key mapping
- Make customization key mapping discoverable
- Refactor react components so JSNES can run a single ROM standalone HOT 1
- Publish emulator components as npm package
- Put back all games that were previously there HOT 2
- Emulator speed HOT 2
- Dragging ROM only works on particular parts of the page HOT 1
- A jsnes frontend with net play support
- can jsnes save?
- Can't Install via Yarn HOT 2
- Add TypeScript to Project HOT 1
- Could you add mobile controls support? HOT 1
- Problems Publishing to Github Pages HOT 2
- 2 player controls don't work on keyboards without numpads HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsnes-web.