bezoerb / filerevbundle Goto Github PK

Hi Ben, I'm working on a PR to support custom asset packages however I've encountered an issue related to base_path (not just for custom packages).

Use case
3rd-party bundles use default package, nothing special here. My front-end bundle, uses package with different basePath. This could possibly be also a CDN base_url for my front-end assets. Resources retrieved with {{ asset('css/style.css', 'mad') }} are then prefixed with the path configured for "mad" package. The configuration is straightforward:

framework:
    assets:
        packages:
            mad:
                base_path: /assets

Problem
Prefixing the base_path! In the old codebase you've had $file = $this->basePath . '/' . $path; in applyVersion() method of PathPackage. Currently, the responsibility for prefixing is left on Asset component (what I think is in tact with Symfony's intention when introducing VersionStrategyInterface) and so the path that comes to applyVersion() as an argument is un-prefixed. This however causes if (file_exists($absReved)) to fail because the path is incorrect - it lacks the prefix. This obviously results into unmatched entry in catalogue as well.

Any help is highly appreciated. Thanks.