Code Monkey home page Code Monkey logo

Comments (11)

mpociot avatar mpociot commented on May 24, 2024 1

Sorry, I’ll update the Readme to mention this.

from laravel-view-xray.

mpociot avatar mpociot commented on May 24, 2024

Do you see any errors in the console output?

from laravel-view-xray.

scottzirkel avatar scottzirkel commented on May 24, 2024

Sorry, meant to mention that. No errors.

from laravel-view-xray.

mpociot avatar mpociot commented on May 24, 2024

Do you see the info:

Ready to Xray. Press cmd+shift+x to scan your UI.
?

from laravel-view-xray.

scottzirkel avatar scottzirkel commented on May 24, 2024

I do not. I do see the Xray comment blocks throughout, so I can see it's there.

from laravel-view-xray.

scottzirkel avatar scottzirkel commented on May 24, 2024

I didn't see it listed, but is jQuery a requirement? I ask because I see this block:

  if (!($ = window.jQuery)) {
    return;
  }

Which is as far as I get. It's returning there.

from laravel-view-xray.

mpociot avatar mpociot commented on May 24, 2024

Ah yeah, it is! :)

from laravel-view-xray.

scottzirkel avatar scottzirkel commented on May 24, 2024

Bummer! Ah well, at least it wasn't broken! 😄

from laravel-view-xray.

waw3 avatar waw3 commented on May 24, 2024

when i press cmd+shift+x i see an overlay also see the bar.. but dont see section blocks highlighted.
this is a fresh install of laravel 5.6 after adding your package and calling php composer make:auth

screen shot 2018-07-19 at 5 01 35 pm

from laravel-view-xray.

mpociot avatar mpociot commented on May 24, 2024

@waw3 The default Laravel application adds a Vue application to the main div.
As mentioned in the readme, Vue removes HTML comments.

You need to add the comments: true parameter to the Vue initialization:

https://github.com/laravel/laravel/blob/master/resources/assets/js/app.js#L20-L22

from laravel-view-xray.

waw3 avatar waw3 commented on May 24, 2024

I’m not using vue. Just an FYI. I did a fresh Laravel 5.6 install
Generated default auth login using make:auth added your package and that’s what I got.

The comments where def there.
Although, I did notice duplicate Count Iterations in the comments x-ray Produces.

I have no clue why the dom didn’t find the layout comment and the section comment. But it does find the toolbar comment.

I also ran a test on ALL nodes for window.document and validated that the node type does == 8. But doesn’t find the slice value.

I will post a link to live code Momentarily

from laravel-view-xray.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.