use a btn instead of shortcuts about laravel-view-xray HOT 9 CLOSED

for more than a reason

• atm u need to support different ops keys "ctrl vs cmnd"
• the user might have already assigned the same keys for something else "os level or site level"
• using a btn is much easier and u dont need to reach for ur keyboard each time u want to disable/enable as for debugging u r mostly going to use the mouse.
• using a shortcut means the user have to memorize it, what if there are more than one dev on the same project ?
• keycodes not persistent across browsers nor easy to maintain

from laravel-view-xray.

Any reason why?

from laravel-view-xray.

@mpociot any updates ?

from laravel-view-xray.

Do you want to provide a PR with the changes for this?

from laravel-view-xray.

do u want to keep the shortcuts or remove em ?
for btn styling, do you want it to be configurable or static?

and to make sure, this is the part that should be replaced

correct ?

from laravel-view-xray.

I guess we can just make the button styling static.
What do you think of having the shortcuts configurable? Not the actual keys, but the ability to enable/disable them?

And yes - that's the part that needs to be updated

from laravel-view-xray.

What do you think of having the shortcuts configurable? Not the actual keys, but the ability to enable/disable them?

yeah why not, but if you are going to make it configurable why not go the extra mile and make the shortcut it self configurable ?

on a side note,
i was thinking maybe we can turn the whole UI into a browser extension, something like vuejs, blackfire, etc.. but am not sure how it will be done 😞

from laravel-view-xray.

yeah why not, but if you are going to make it configurable why not go the extra mile and make the shortcut it self configurable ?

That's a great idea!

And I also thought about turning this (among other things) into a browser extension, but haven't found the time to look into it in more detail

from laravel-view-xray.

okay so to keep things simple, lets replace the shortcuts with a btn for now & the extra config could be added later to the browser ext, this way we won't need to do big changes to the package.

btw we can open a new issue for the browser ext idea, maybe someone can pick it up.

also i was thinking of dropping jquery, again it would make things easier when converting to an ext.

from laravel-view-xray.