Code Monkey home page Code Monkey logo

photo-editor-android's People

Contributors

ahmedadeltito avatar ma7moudovic avatar mrabelwahed avatar rkhater avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

photo-editor-android's Issues

Requirement

I want to set text always on top of canvas layer. suppose i add one image and text then that text should always on top even when i select image. Please give me some suggestion.

Thanks
Anmol

photoEditorSDK.saveImage(folderName, imageName);

Not working for Android 11 as we cannot use android:requestLegacyExternalStorage="true" to be able to access

Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES) now

Black screen on Samsung J5

Device: Samsung Galaxy J5
Model number: SM-J500M

Using the lib's app in the above mentioned device, I get a black screen wether I import image from gallery or take a photo using the camera in the app.

Tested also in a Motorola G5 and the app worked fine (no black screen).

Add text

Hi, amazing library which i'm thinking of using in my project.

I got an issue during added text. I added three texts. When I clicked on any text for edit, last entered text got disappeared. Also, instead of editing same text, new text gets created. How do I resolve these issues?

Thanks.

Does it support Cropping of image?

I have installed app , But i didn't see any option for cropping of image,scale, rotate .
But it's mention in feature list in README.

Is it the case that it's implemented in SDK but not used in sample app?

Please let me know if to enable feature some procedure i need to apply.

Brush gone when add text

I draw something on the image then i add text, when the keyboard show, all brush clear.

How can i fix that?

Which is the Show Photo Editor Popup function?

HI,
I integrated the iOS version of API and its working fine. But in the android version how to show the Photo editor popup screen same like iOS version?

In iOS it opens when executes; present(photoEditor, animated: true, completion: nil)
But how the same in android?

I followed all steps and called photoEditorSDK = new PhotoEditorSDK.PhotoEditorSDKBuilder(PhotoEditorActivity.this)
.buildPhotoEditorSDK();
but nothing happened.

Zoom in / Zoom out / Pan

Is it possible Zoom and Pan the image when drawing ?

I need to draw on top the images details that is not possible without zooming the image.

So, I am wondering if it's possible, somehow, we be able to do zoom the image as well as pan the zoomed image during the drawing (Pencil option).

The draw layer should be updated like the original image layer.

Best Regards.
Kleyson Rios.

Undo functionality for drawing.

Is there any way I can get an intermediate state. So that I can revert to same. Something like undo functionlity for the drawing as well?

adding better isViewInBounds check

We salute you for this library, we are using it in our current project, it saved us a lot of time.

i added an extra functionality that was needed, and i think it should be default it the library

when you move the image/sticker/text vertically the isViewInBounds() works perfectly but when moving horizontally it does not cuz it fits the width of the screen to the touch position never exceed the bounds of the container view.

so i added that functinallity

my fork https://github.com/AhmedNTS/photo-editor-android

New logo/icon

Hi, I am a graphic designer, I want to help others in graphic design.

After I reviewed your project, you have no logo on this project. Therefore I want to contribute to this project by creating a new logo / icon. what do you think?

How to use

It's seem a good sdk, but i can't understand how to import to my project,

Installation and Usage is empty
This is no .jar file, no compile like
compile 'com.adobe.creativesdk.foundation:auth:0.9.1251'

when i use
compile project(':photoeditorsdk')
i get error
Error:(52, 0) Project with path ':photoeditorsdk' could not be found in project ':app'.

This sample has two floder has AndroidManifest.xml
photo-editor-android-master/photoeditorsdk/src/main/AndroidManifest.xml
photo-editor-android-master/app/src/main/AndroidManifest.xml
I can't know what is the main

Please help:)

Ionic plugin

Is there any way to use this library in ionic cordova as plugin

Image postion

why image which we are taking coming in centre?
could you have any other code like where we press it should come there
i think its just position code
hope you understand

Attempt to invoke virtual method 'void android.graphics.Canvas.drawColor(int, android.graphics.PorterDuff$Mode)' on a null object reference

You can use the app sample to simulate the error.

After the photo editor start, if we click on the "Clear All" button as the first action on the editor the following error happen:

2019-05-14 13:17:52.297 11032-11032/com.ahmedadeltito.photoeditor E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.ahmedadeltito.photoeditor, PID: 11032
    java.lang.NullPointerException: Attempt to invoke virtual method 'void android.graphics.Canvas.drawColor(int, android.graphics.PorterDuff$Mode)' on a null object reference
        at com.ahmedadeltito.photoeditorsdk.BrushDrawingView.clearAll(BrushDrawingView.java:121)
        at com.ahmedadeltito.photoeditorsdk.PhotoEditorSDK.clearAllViews(PhotoEditorSDK.java:184)
        at com.ahmedadeltito.photoeditor.PhotoEditorActivity.clearAllViews(PhotoEditorActivity.java:216)
        at com.ahmedadeltito.photoeditor.PhotoEditorActivity.onClick(PhotoEditorActivity.java:340)
        at android.view.View.performClick(View.java:6597)
        at android.view.View.performClickInternal(View.java:6574)
        at android.view.View.access$3100(View.java:778)
        at android.view.View$PerformClick.run(View.java:25885)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Gradle Dependency

How do I compile this library in my android project i.e how do I add it as a dependency

App crashes when the user clicks on "Clear All" button in the photo editor screen.

Hi,

I've observed the following crash in the sample app. It crashes when the user clicks the "Clear All" button in the photo editor screen.

Steps to reproduce:

  1. In the sample app, click the "Choose From Camera" button.
  2. Capture a photo.
  3. In the photo editor screen, click the "Clear All" button without modifying the photo.
  4. The app crashes throwing NullPointerException.

Exception log:
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.graphics.Canvas.drawColor(int, android.graphics.PorterDuff$Mode)' on a null object reference
at com.ahmedadeltito.photoeditorsdk.BrushDrawingView.clearAll(BrushDrawingView.java:121)
at com.ahmedadeltito.photoeditorsdk.PhotoEditorSDK.clearAllViews(PhotoEditorSDK.java:184)
at com.ahmedadeltito.photoeditor.PhotoEditorActivity.clearAllViews(PhotoEditorActivity.java:216)
at com.ahmedadeltito.photoeditor.PhotoEditorActivity.onClick(PhotoEditorActivity.java:340)
at android.view.View.performClick(View.java:5198)
at android.view.View$PerformClick.run(View.java:21147)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

It would be great if this issue is fixed quickly as I'm planning to integrate this lib.

Thanks & regards,
Debu

Save image with original size

Hi,
Can i save image with original size? As an example, the camera takes pictures at a resolution of 3264x2448. After editing the image, it is saved is the same as when the screen resolution.

I'm used load photo to editor:

void loadPhotoEditor(String filePath) {
        mPhotoEditor.clearAllViews();
        Bitmap photo = BitmapFactory.decodeFile(filePath );
        photoEditorView.getSource().setImageBitmap(photo);  
 }

and save function

@SuppressLint("MissingPermission")
    @OnClick(R.id.btnSave)
    public void onbtnEditSaveClicked() {
        progress = ProgressDialog.show(this, "İşleminiz Yapılıyor....",
                "Görsel kayıt ediliyor", true);
        mPhotoEditor.saveImage(mCurrentPhotoPath, new PhotoEditor.OnSaveListener() {
            @Override
            public void onSuccess(@NonNull String imagePath) {
                if (progress != null) {
                    progress.dismiss();
                }
                Toast.makeText(InspectionDetail_PhotoActivity.this,
                        "Değişiklikler kayıt edildi.", Toast.LENGTH_SHORT).show();
                editMode(false);
                fileAdapter.notifyDataSetChanged();
            } 
            @Override
            public void onFailure(@NonNull Exception exception) {
                if (progress != null) {
                    progress.dismiss();
                }
                Toast.makeText(InspectionDetail_PhotoActivity.this,
                        "Değişiklikler kayıt edilemedi: " + exception.getMessage(), Toast.LENGTH_SHORT).show();
                editMode(false);
            }
        });
    }

REFRESH THE GALLERY

Hey,

Thank you very much for this library it's the best free photo editor around.
Am using it in an app but i had to add some code to refresh the device gallery after saving the image otherwise one has to first restart their device in order to see the saved image.

Heavy Lag

Hi! Thank you for your project, it helps me a lot!
But I have a problem here, this applications have a heavy lag in Samsung C5. But it works very well in my LG G5. How should I reduce the lag? Do you have any suggestion?

Default font

Hello, is it possible to change the default font for this package? Thank you

Black Screen On Redmi 4A

Device: Redmi
Model number: Redmi 4A
Using this lib's app in the above mentioned device, I get a black screen whether I import image (which was clicked by camera) from gallery or take a photo using the camera in the app.

Re-edit text.

This is an amazing library as I have seen till for editing images. I am using this library in my project. But there is one bug. Pls, resolve it. need your help buddy.

Bug:

Whenever we try to re-edit the already written text. Always last added index text will get edit, not the particular text.

ex: if I added 4 texts and try to re-edit anyone of them always it will make changes to 4th text, not the remaining 1,2 & 3rd texts. if I select 1st index to re-edit then it should edit only 1st index text. But 1st index text remains as it is & edits the 4th index text.

Emojis File Modification

Hi,
I have used your app in one of my projects and i want to know that how can i use my own emoji ttf file?I tried with one of my files but it was saying that addfontfromasset failed to create fonts.Please help in this.Thanks in advance

Scaling added image

When scaling added image it stops scaling at one point, meaning, if I want to add an image then scale down to make it very small I can't because it stops scaling. How to fix this issue?

Some feature needed

Hey first of all thumbs up for your library. I have seen different edit libraries but this one satisfy my needs although some features are required. I have one question is it possible to get the position of each elements on the screen before saving the picture
e.g Position of Text , Sticker Because I want to save this entire project while user is editing and will re load to him when he will want to resume the old editing. Is it possible. If it is then can you please do it for me?

Drawing issue

There's an issue with drawing tool on Oreo 8.
If you draw using the drawing tool, and then try to insert the Text, the drawing is erased.
Steps to reproduce:

  1. Tap on the draw icon and start drawing using some color other than black.
  2. After some drawing, tap Done.
  3. Tap on the text icon and start typing some text using some color other than black.
  4. Tap outside the text view to dismiss it.
  5. Drawing disappears.

It works fine on other OS versions, but this happens on Oreo 8.

Re open the drawing after saving

hey,
I save my drawing in local file and when i open it create a single Bitmap of all images and text .
Or if i open as a background then it place all items on background.
I cannot able to re edit that file ..
any solution..

Issue

is it possible to drag , zoom in and zoom out background image ?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.