bettergov / foiamail Goto Github PK

https://developers.google.com/gmail/api/v1/reference/quota

I forgot to init_labels before init_msg, leading to a couple hours of manual fixing. Let's protect against these sorts of brain farts.

Either:

• set up an input prompt (don't see any agency labels... are you sure you want to send?)
• create agency label on send

assigning to patrick pending invite acceptance

TODO:
come up with a testing checklist. make sure to verify functionality of new features, including:

• #32
• #40

See response report script

Mainly Sheets, but check other APIs too.

See auth.auth.test_cred

include some screenshots or something

Right now when shipping attachments, the app only publishes to Google Drive attachments on the whitelist.

Let's switch to using a blacklist of common image file formats.

confirmed

work this into msg.compose.distribute so you can follow a two-step process:

1. prep drafts
2. send prepped drafts

And maybe reorganize the readme

1. race condition? in msg.label.create_labels()
2. nesting isn't working with "agency/" naming convention

make a list of unsent agencies and try again

Google Doc? Email draft? These both seem like better options to me than a local file.

See alsip

Occasionally the application has run into rate limits. These incidents were rare and typically self-resolving. But I've tried to document incidents and then either optimize API calls or tune back crontab frequency. See #16 & #36.

typographical bug prevented NA from returning as an agency status

todo: verify contacts load correctly

(see race condition described in issue #18 )

Adding new contacts mid-project would not generate corresponding labels.

See MK/JG emails 10/31/19

Maybe init labels as contacts are loaded (currently via UI) or as drafts are prepped to ensure labels and agencies stay in sync.

Alternatively, quick fix could involve re-running init_labels(). (Untested)

I'm working on building a similar (but not identical) project to this one and came across this line in the get_cred method of the auth.py script:

if ... sorted([x for x in credentials.scopes]) != sorted([x for x in scopes]):
    # create credentials

Is there a compelling reason to mandate that the list of scopes in the auth.py file be exactly the same as the list of scopes you have permission for?

Changing this line to

if ... not credentials.has_scopes(scopes)

should take care of this if you only want to make sure that you have all of the permissions you need.

Currently, loads into Other Contacts in GMail interface

Verify this is does not block get_contacts()

todo automate

fixed in 7971e4d

So there's a place to save the response report buffer file

make sure that none of the new contacts are

and add this to the user manual

e.g. Deerfield Library, East Dundee

confirmed

xlsm, ods, xlt

and what about the handful that have no extension?

also, why didn't these attachments ship?
https://mail.google.com/mail/u/0/#inbox/162bfcca6867e702
https://mail.google.com/mail/u/0/#inbox/162bfcc995288a7e (note there's no ext on the xls file)

see the rest of "done" agencies in response report

Both were sent, responded, marked done and shipped ...

So why is their status/threads blank on the response report?

confirmed

HttpError: <HttpError 429 when requesting https://www.googleapis.com/gmail/v1/users/me/labels?alt=json returned "User-rate limit exceeded. Retry after 2018-04-27T17:20:36.724Z">

The error hits on labels but it appears the root issue is greedy gmail.users.threads.list

TODO: optimize threads.list calls

see mgr.py line 16 (TODO: fix)

So far, only seems to affect attachment collection for a small number of agencies, e.g.

skipping Troy FPD
Governor's State University failed <HttpError 400 when requesting https://www.googleapis.com/drive/v3/files?q=name%3D%27Governor%27s+State+University%27&alt=json returned "Invalid Value">
skipping DeWitt County

TODO: fix

Conversely, kick this process over to the UI and skip the step in CLI.

TODO: Ask Patrick and Jared.

for things like file paths, subject lines, etc.

msg.compose.distribute assumes that we've created drafts using prep_agency_drafts. Decouple these so that we aren't forced to create drafts to send them.

If necessary (low priority)

refactored in d965e83

verify checks are in place to:

1. identify unsent drafts
2. send unsent drafts

see #4

e.g.., test contacts may get returned even after deleted and replaced

TODO: document this or find a code workaround

e.g. contacts

TODO: remove hardcoded parameters if possible, or else start a global config file to assign that