bespokejs / bespoke-keys Goto Github PK

Hi there, I'm using bespoke-keys to scroll to slides using the arrow keys:

bespoke
  .from('body', [bespokeKeys('vertical')])
  .on('activate', ({ slide }) => {
    slide.scrollIntoView({
      behavior: 'smooth',
      block: 'center',
      inline: 'nearest',
    });

    return false;
  });

But the browser scrolls a bit too far. After troubleshooting I found out it's because the default arrow key event causes a scroll too, calling event.preventDefault would fix this.

Would this be something to add to the code of this plugin? An alternative would passing keydown event so it can be used inside the activate event handler. Thoughts?

Hi @markdalgleish. Would it be ok to update the dependencies for the plugin? I'd be glad to do a PR if you think it's a good idea.

Thanks!

Don't intercept key events that are being sent to an editable input, such as a text area.

Presenters often like to use editable inputs in the presentation to explain concepts, such as an editable source code block. Currently, it's impossible to type into one of these elements without triggering the slide navigation. The plugin should check to ensure that the element is not an editable input before acting on the key event.

Many applications, presentation systems or otherwise, have gotten us used to being able to press the "f" key to enter fullscreen mode. I keep stumbling over this missing keybinding in bespoke.js while presenting. I hope to see this supported by bespoke-keys out of the box.

Ignore keydown events if a modifier key is active (ctrl, shift, alt, etc). This prevents bespoke-keys from intercepting keyboard shortcuts, such as navigating tabs in the browser and such.

Hey @markdalgleish, do you have any interest in a shift + space keybinding to navigate to the previous slide, or is that out of scope for this plugin?

I can submit a PR if you think it would be a good fit.