bernicecpz / kumite-scoring-board Goto Github PK

Describe the bug
Because there are currently no limits set on the amount of time that you can increment, a user can increment the time indefinitely. Although before starting the timer the display seems to be correct, after running the timing, you get such strings:

which is probably not the intention.

To Reproduce
Steps to reproduce the behavior:

1. Open the application.
2. Increase the timer by spam pressing +/=.
3. Start the timer.

Expected behavior
The timer should always be displaying time in the form of min min: second second.

Suggestion
Set the timer increment limit to 59:30 minutes. This is because 1 hour matches are highly unrealistic anyway so longer times are probably not necessary.

Describe the bug
In the application, +/= is used to increment the timer by 30 seconds. This is implemented as the key code 187 in the application JavaScript. However, this key code is not consistent across browsers, particularly Firefox:

To Reproduce
Steps to reproduce the behavior:

1. Open the application in Firefox.
2. Try to increment the timer using +/=. No changes appear for the timer.

Expected behavior
The timer should have been changed according to the shortcut.

Suggestion
Instead of using +/= as the shortcut, how about something like tab that is consistent across the major browsers in terms of key codes? Otherwise, just including key code 61 for Firefox will include other keys for the other browsers as well.

This would also entail changes to the keyboard layout diagram.