berlin-ab / cexpect Goto Github PK

[] It might be useful to try to guard against mutliple header file inclusion. E.g. include the content of each header file within #ifndef _FILENAME_H_ #define _FILENAME_H_ #endif blocks

[] It is not great (although for example Postgres does it some) use sizeof(type) in alloc functions. Especially if that type is char then some critique might follow. It is a bit more accepted to write type *var = allocfunc(nelems * sizeof(*var));

[] exit(func(foo)) is not really great since you probably want to be explicit of the exit status regardless of platform and or shell running it. One of the ways to write this is along the lines of

     if (func(foo))
          exit(EXIT_FAILURE);
     else
         exit(EXIT_SUCCESS);

[] Also the main function in the examples does not have a return value. Although the framework is expected to exit a return value will be asked from most compilers.

[] Use of sprintf is generally discouraged in preference to the safer snprintf which takes a size argument.

• In the expression "%s", (expected_value ? "true" : "false") the parenthesis means something else, and although most compilers will not complain and do the right thing, they can and should be omitted.

Pulling from this list:

https://en.wikipedia.org/wiki/C_character_classification

Implement matchers in the form of:

expect(test, 'a', is_char_equal_to('a)); // passing
expect(test, 'b', is_char_equal_to('a)); // failing

• char
• signed char
• unsigned char
• unsigned ints
• short
• short int
• signed short
• signed short int
• unsigned short
• unsigned short int
• int signed
• signed int
• unsigned
• unsigned int
• long
• long int
• signed long
• signed long int
• unsigned long
• unsigned long int
• long long
• long long int
• signed long long
• signed long long int
• unsigned long long
• unsigned long long int
• float
• double
• long double

1. create a suite
2. add tests
3. create group for suite
4. add tests to group
5. tests should run and report by group

I'd like to have TAP as an available option as a part of the core distribution.

See https://testanything.org/ for details of how to implement.

Given an empty list:

List * make_list()

When I make an expectation using a not matcher and the is_list_empty() matcher:

expect(test, list, not(is_list_empty()));

Then the test should fail.

Note: I'm not exactly sure what the expected and actual messages should be. This might require some pre-refactoring to do well.