bergey / stl Goto Github PK

Hi,

I noticed that the files I export are not loadable in e.g. meshlab. The problem is that the vectors contain commas in the output, which should not be the case in the STL format [1]:

FIX: in Graphics.Formats.STL.Printer
v3 (x, y, z) = mconcat $ intersperse comma [floatDec x, floatDec y, floatDec z]
where
comma = stringUtf8 ", "
->
v3 (x, y, z) = mconcat $ intersperse (charUtf8 ' ') [floatDec x, floatDec y, floatDec z]

Regards,
Georg

[1] http://en.wikipedia.org/wiki/STL_(file_format)

It would be great if there was a function for reading any .stl file, both binary and ASCII.
I guess I could write one myself but it would be better if it was part of this library so everyone can benefit from it.

GHC 8.4.1 is out with base 4.11, please adjust package constraints.

Also, this time, please make a release on hackage; the current version 0.3.0.5 is not even published there.

The text-format pretty-printer is very slow and blows the stack. The binary format is probably the right choice anyway for large files, but it would be nice to improve the text output also. The time seems to be mostly in the float and double functions from pretty. Is pretty actually using show for numbers?

Data.ByteString.Builder is using show, with a code comment to instead use double-conversion.

For example:

• define normal :: Maybe Vector
• write Nothing as (0,0,0)
• read (0,0,0) as Nothing
• provide a function to fill in missing values

Is it worth distinguishing STLs with possibly missing normals at the type level?

I deleted upper bounds to build with current base, and found no problems.