The tensorflow-xsmm's discuss from benoitsteiner

benoitsteiner / tensorflow-xsmm Goto Github PK

View Code? Open in Web Editor NEW

Improved performance for TensorFlow on Intel hardware.

License: Apache License 2.0

Python 40.91% C++ 48.13% C 0.33% CMake 0.23% Java 0.84% Objective-C 0.02% Objective-C++ 0.11% Makefile 0.05% Shell 0.48% Jupyter Notebook 2.45% Go 1.27% Batchfile 0.01% LLVM 0.01% Ruby 0.01% Perl 0.01% PureBasic 0.03% PHP 0.01% HTML 5.11% Smarty 0.01%

tensorflow-xsmm's Issues

configure script fails for MKL fails for multiple invocations

When mkl_include symlink already exists, the configure script tries to write the new include symlink in the directory pointed to by mkl_include. This is easily fixed by adding the -n option to ln.

This is also present in the current tensorflow master branch, but I think this is the upstream.

diff --git a/configure b/configure
index 23603a9..7605a2c 100755
--- a/configure
+++ b/configure
@@ -252,14 +252,14 @@ if [ "$TF_NEED_MKL" == "1" ]; then # TF_NEED_MKL
       ln -sf $MKL_INSTALL_PATH/${MKL_ML_LIB_PATH} third_party/mkl/
       ln -sf $MKL_INSTALL_PATH/${MKL_ML_OMP_LIB_PATH} third_party/mkl/
       ln -sf $MKL_INSTALL_PATH/include third_party/mkl/
-      ln -sf $MKL_INSTALL_PATH/include third_party/eigen3/mkl_include
+      ln -sfn $MKL_INSTALL_PATH/include third_party/eigen3/mkl_include
       loc=$(locate -e libdl.so.2 | sed -n 1p)
       ln -sf $loc third_party/mkl/libdl.so.2
   elif [ -e "$MKL_INSTALL_PATH/${MKL_RT_LIB_PATH}" ]; then
       ln -sf $MKL_INSTALL_PATH/${MKL_RT_LIB_PATH} third_party/mkl/
       ln -sf $MKL_INSTALL_PATH/${MKL_RT_OMP_LIB_PATH} third_party/mkl/
       ln -sf $MKL_INSTALL_PATH/include third_party/mkl/
-      ln -sf $MKL_INSTALL_PATH/include third_party/eigen3/mkl_include
+      ln -sfn $MKL_INSTALL_PATH/include third_party/eigen3/mkl_include
       loc=$(locate -e libdl.so.2 | sed -n 1p)
       ln -sf $loc third_party/mkl/libdl.so.2
   else