For example, take an Amazon. In its loot stats page it has a loot item named Skull. The page of this item is actually named Skull (Item).

The 'FixLootStatistics' usecase incorrectly adds an item 'Skull' to the loot list of the creature.

One way to fix this would be to keep the usecase as dumb as it is and fix the item naming in the loot parser on the wiki.

Another option would be to add a list of exceptions to the usecase (i.e. if you find the name 'Skull' on a loot statistics page, translate this to 'Skull (Item)').

The problem with the bot overwriting its own edits is solvable by only editing each page once.

1. obtain data from creatures, store in a Set
2. obtain data from items, store in a Set
3. filter out the intersecting pairs in the two sets
4. output results as two sets: a set of items missing from creature pages, and a set of creatures missing from item pages

This should reduce the current algorithm from O(n x m) performance to O(n + m) where n, m are creatures and items.

The current regex in the method makeListOfLootItems() can't deal with a third optional parameter in Template:Loot Item containing rarity info. An ugly work-around is currently used to deal with this.

@Sixish, if you have any ideas, please let me know.

TibiaWikiBot doesn't seem to be responsible for anything. It seems TibiaWikiBot should be responsible for wrapping MediaWikiBot and WikiRepository so that FixCreatures shouldn't have to interact with those classes.

FixCreatures and FixItems should be connected in some way. They are fundamentally tasks for TibiaWikiBot. It's more appropriate to have TibiaWikiBot acting upon the task, than the task creating its own bot. Alternatively, FixCreatures could extend TibiaWikiBot and be a bot in itself.

Happened in this this edit.

After the update to Kotlin the jackson parsing is broken. Notably the Percentage class is weirdly constructed.

Add something like a jacoco xml coverage output file so sonarcloud can keep track of test coverage?

Don't call the wiki directly but call the rest resources published by TibiaWikiApi instead.

When setting default values for creatures the following rules must be applied:

• it is ok to fill behaviour with a question mark when the runsat parameter is empty;
• the behaviour parameter should not be filled with a question mark when the runsat value is non-null.

Original report by Hunter of Dragoes:

Hey Bennie,
on April 28, your bot added missing creature parameters and even assigned default values to some of them. This was the case of blank behaviour parameters which were filled with Unknown. This caused an undesired situation when the Behaviour field was not blank (although the parameter was), but filled with a string which depends on the runsat value. Now, those pages have the word Unknown followed by the runsat's string. For example, you can check the Stalker page. Having said this, can you set your bot to remove the content from behaviour when runsat has a non-null value?

Increase test coverage to 60%

Molx reported: We need an exception so the bot doesn't add 'Part of a Jester Doll' to the loot table of Undead Jesters. It's a disambig page

Message by Hunter:

Yesterday I removed The Crown of the Percht Queen and Giant Shimmering Pearl from The Percht Queen.
I believe your bot added those two items because they are listed on the loot stats page. Well, the bot can't read this, but we have a warning box which explains the Percht Queen drops 2 items named The Crown of the Percht Queen and 2 items named Giant Shimmering Pearl, since they can't be distinguished on the loot message, those disambiguation links are used on the loot stats page. This, obviously, doesn't apply to the creature page, on which we link to the 4 item pages (and don't link to those disambiguation pages).
https://tibia.fandom.com/wiki/The_Percht_Queen?diff=896552

Acceptance criteria:

• When adding loot from the loot statistics pages, never add items The Crown of the Percht Queen and Giant Shimmering Pearl to creature The Percht Queen

[at]Bennie, I noticed your bot was adding | sounds = {{Sound List|}} to all item pages it edited, can you change it so it won't add this parameter anymore (and won't remove it from items that emit sounds when used)?

Dependabot couldn't find a pom.xml for this project.

Dependabot requires a pom.xml to evaluate your project's current Java dependencies. It had expected to find one at the path: /pom.xml.

If this isn't a Java project, or if it is a library, you may wish to disable updates for it from within Dependabot.

View the update logs.

Seems very strange that the bot operates (saves) when the debug mode is on, and writes to logs when it's off.

Assumed requirement: any creature, for example https://tibia.fandom.com/wiki/Priestess_of_the_Wild_Sun, should not contain the entry 'Secret Instruction' in its loot list, even though the loot statistics page contains it.

Avoid adding Orc Tusk (probably to various Orc creature pages).

In one run, these two usecases can modify the same creature, essentially overwriting each other's commits. Possible ways to fix:

• Have a cache of items/creatures on a higher level, outside of the separate usecases. Only save after all usecases are done.
• Fix getting the latest state from MediaWiki API. There must be a way to not get a cached version but a live view.

It is bad practise to have all code in one main file, it is better to have several classes with their own methods.

XarkostToday at 2:36 PM
A few months ago I removed "Old Rag" from cyclops drop loot. I just realized the bot added it back. It also exists in the loot on Troll and Wolf pages. I assume this is because it appears in the "Dropped By" section on the item page https://tibia.fandom.com/wiki/Old_Rag. I removed this because the drop is related to a special event, similar to the Envelopes from the Wizards and these don't appear. Is there a solution for this? Does the Old Rag page have to be marked as related to an event?