benjaminbolling / rsw Goto Github PK

Support different shift occupancy per specie, needs supporting functions in both phases.

The Requirements.txt should have atleast a range of version support or support newer versions.

openjournals/joss-reviews#3431

Having spaces in the folder names seems to cause problems

D:\joss review\RSW>python RSW.py
python: can't open file 'D:\joss': [Errno 2] No such file or directory

Replacing space with hyphen removes the problem.

D:\joss-review\RSW>python RSW.py

D:\joss-review\RSW>

Possible solutions:

• https://stackoverflow.com/questions/50011733/python-error-filenotfounderror-errno-2-no-such-file-or-directory/50011910
• https://stackoverflow.com/questions/12201928/python-open-gives-filenotfounderror-ioerror-errno-2-no-such-file-or-directory

openjournals/joss-reviews#3431

Create better solution for exporting file (file format options in native or non-native window).

Support changing starting weekday (e.g. Mon for Mon-Sun, Sun for Sun-Sat, etc.).

E.g. changing from E (Evening) to A (Afternoon).

Create an advance export function for Microsoft Excel's xlsx file format.

3 points regarding the software paper:

First:
" State of the field: Do the authors describe how this software compares to other commonly-used packages?"

Can you please extend the paper to compare your current software with existing software that has the same/similiar functionality? For example, add a "related work" or "state of the art" section to the paper. Furthermore, please compare your current software with currently existing methods in terms pros/cons so it is clear for the user why they have to use their system over other systems.

Second:
"References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?"

I believe citation is missing from many parts of the text. For example

"....All around the world, research institutes and industrial complexes make use of workforces 6 working multiple shifts per day in order to utilise maximum efficiency and -profitability of the 7 facility...." Citation for this statement? Many of the equations used are also missing citations. Kindly make sure you have citations of all other people work in your paper and/or any claims you make in the paper-

Three:
Can you please add a high-level software architecture flow to your paper? If you check here "https://c4model.com/". A Level 3 component diagram will be highly beneficial.

Can you please add the automated test part to your repo and highlight what each function tests?