benhoskings / babushka-deps Goto Github PK

On Lion I get the following:

benhoskings:TextMate.app {
  meet {
    Following redirect from http://download.macromates.com/TextMate_1.5.10.zip
    Downloading http://dl.macromates.com/TextMate_1.5.10_r1631.zip... done. 
    Extracting TextMate_1.5.10_r1631.zip...    invalid byte sequence in US-ASCII
    Check /Users/michael/.babushka/sources/benhoskings/textmate.rb.
    You can view a more detailed log at '/Users/michael/.babushka/logs/benhoskings:TextMate.app'.

Extracting the downloaded file manually doesn't cause a problem. Perhaps an issue with how
Archive: /Users/michael/.babushka/downloads/TextMate_1.5.10_r1631.zip is being run?

The offending entry seems to be:
inflating: TextMate.app/Contents/SharedSupport/Bundles/AppleScript.tmbundle/Commands/Compile.tmCommand

Hi Ben,
Just learning Babushka - I think the URL you're using for system wide installs is incorrect. The correct command (run as root) is :

bash < <(curl -s https://rvm.beginrescueend.com/install/rvm)

Attempting to run

$ babushka benhoskings:rvm

and selecting system wide install fails with the following in the error log (couldn't get the markdown to display nicely):

benhoskings:rvm {
(defining rvm against Babushka::Dep::BaseTemplate)
setup not defined.
$ echo $SHELL
/bin/bash
$ bash -l -c "which rvm"
stdin: is not a tty
prepare not defined.
meet {
before not defined.
Install rvm system-wide [y] Installing rvm using rvm-install-system-wide... $ bash < <( curl -L http://bit.ly/rvm-install-system-wide )
sh: Syntax error: redirection unexpected
failed
}
$ echo $SHELL
/bin/bash
$ bash -l -c "which rvm"
stdin: is not a tty
} ✗ benhoskings:rvm
in dir /root/.babushka (/root/.babushka) {
Saving /root/.babushka/sticky_vars
}
in dir /root/.babushka/vars (/root/.babushka/vars) {
Saving /root/.babushka/vars/benhoskings:rvm
}

should use nginx_prefix instead

met? {
shell('locale').val_for('LANG')[locale_regex(locale_name)]
}

I guess the reason it's not met is "Setting the locale doesn't take effect until you log out and back in.".

Problem: on a system of mine I had %admin ALL=NOPASSWD:ALL already in the sudoers file. It is ubuntu-10.04 LTS, however, modified by the hoster. The problem with the line is, that users of group admin cant use for instance sudo -u postgres, because the =(ALL) is missing.

The dependency:
dep 'admins can sudo' do requires 'admin group' met? { !sudo('cat /etc/sudoers').split("\n").grep(/^%admin/).empty? } meet { append_to_file '%admin ALL=(ALL) ALL', '/etc/sudoers', :sudo => true } end

Maybe we should grep for the entire line in met? In meet, we could let the user decide whether to overwrite the line or not. What do you think?

the nginx source dep doesn't install because it can't find the upload module.

Upon looking, the upload module (an extra_src) is getting downloaded, extracted and immediately deleted.

If you comment out benhoskings:babushka/lib/babushka/asset.rb:64 it works perfectly well.

Not sure why it's acting how it is, but if i figure it, i'll go ahead and submit a pull request in the appropriate place.