benezivas / algobattle-web Goto Github PK

The teams of our lab course reported that they were unable to use the upload function that is accessible in the description of a given problem. They were able to open the file upload dialogue, but subsequently selecting the Upload button did not result in any response from the system.

We are able to reproduce this error with our LuFGTI team on algobattle.org. This seems curious, as this did work before.

Minor bug, reproducible by simply opening a problem description and changing the team view.

In the upload dialog for generators or solvers, problems currently inactive (Pairsum, 2D Knapsack) are still selectable. However, when attempting to actually upload a program for such a problem, the upload is denied (as probably intended). I'd suggest to make inactive problems not selectable at least, maybe even remove them from the list completely.

As of now, when viewing a result, the distribution of the total number of points to the team members is shown.
It would be nice to see, in an additional column when viewing the details of a match, which proportion of the total points a team achieved, in percent.

As it is sometimes desirable to run matches without any points, or when distributing a number of points that make it hard to calculate this proportion in the head, this allows to judge how well a team did in a match at a glance.

Of course, when 100 points are to be distributed, this information is essentially identical to the number of points achieved, but in all other cases this seems useful to me.

Currently, when logging in, a mail with a login token is sent. This token does however not expire when used once: When e.g. opening a private tab, the same token allows for another login, meaning it does not expire upon use. It would be best if every login token can only be used once.

When receiving a token, it would also be helpful to communicate for how long they are valid until they expire.

When selecting the detail view of any problem and subsequently selecting the settings, the link is not followed. Instead, settings replaces the problem name in the url, resulting in a faulty link.

Example:
https://www.algobattle.org/problems/WS23%2F24/Pairsum becomes
https://www.algobattle.org/problems/WS23%2F24/settings

Currently, points are awarded in battles and rounded to the first decimal point. When editing a result which such partial points, it can however not be saved again, as the mask demands an integer value for points.

Right now, the latest uploaded solver/generator is the one being used in battles. It would be nice to have an option to set a specific generator/solver as the 'active' one for a given problem (default: the latest one, as it is now).

When uploading a .algo file that contains a faulty problem.py (e.g. when importing packages that are not set as a requirement in the algobattle.toml) via the upload dialogue, the mask goes through without displaying an error and a new problem is displayed in the list of all problems.

When viewing this newly created problem, the description and schema are not displayed, suggesting that something failed, but what exactly failed cannot be seen by the uploading person, as the appropriate error message is only displayed in the server logs. It would be nice if the user could get feedback that the problem creation did not actually succeed, even better if a concrete reason could be given.

After about 30 results -- which awarded points --, the dates of battles, which are used as label for the x-axis of the results graph, are not correct. The dates of the first few battles instead seem to be used.

The login button does not do what its label states. It would be more intuitive if it read something such as Send Login Link.

When choosing a date and time in the framework, e.g. when creating a new problem, the datetime picker interface does not display an hour and minutes selection using Firefox (120.0.1). This is however the case when using Chromium (120.0.6099.109).

When editing an existing result, e.g. in order to remove a team from a battle that did not participate or in order to edit points, one has to to manually select for each team which generator and solver should be associated with the result.

The date field is also behaving unintuitively: The result is saved with a starting date that is precise up to a second, but non-zero seconds may not be saved.

It would be nice if the editing mask would be filled with the required data such that single changes can be made without having to select and edit multiple other fields before being able to save.

It would be helpful to be able to configure that maximum size of a generator/solver that a user may upload. Right now, in the default configuration, the webserver already rejects such files when they are 15MB large.

Right now, the only visible logs for problem are those published for all members of the tournament. For debugging purposes, it would however be very helpful to also have a verbose log available, by default only readable for admins.

I am trying to add a new result for a problem by hand:

I have created a dummy problem for bug bounties, which is dated in the past. I am now trying to add a result using the "Add result" mask on the corresponding page. Selecting this dummy problem, adding one team, selecting "None" for solvers and generators, dating the problem in the past and then trying to send off this data does not work: Clicking the corresponding button has no effect.

The backend reports "422 Unprocessable Entity", but gives no further information.
Some more detail on the data entered for reproducibility:
Date: 2023-10-31 00:01 AM
Problem: Bug Bounty
Status: Complete
Log File: None Selected
One team added, "Team Tiger" with "None" selected for Solver and Generator, 70 points selected

Assume a team is part of a tournament and already participated in some battles, resulting in some entries in the results tab.

Now assume you change the tournament of the team. If anyone now tries to view these same results, the results tab breaks.