benegon / libredwg Goto Github PK

Hi David,
Did you file a copyright disclaimer or waiver with the FSF?
I'm just looking at your patches, and they are looking good. Nothing earth shattering, but useful.

I've added a mirror at https://github.com/LibreDWG/libredwg, where you could add PR's easily.

• const'ing the API is trivial. I've also added some const'ing in the meantime. I could do that by myself, if you haven't signed.

• The hashmap is to speed up performance of the handle resolver. LibreDWG's concern is not performance, more correctness and ease of use, but why not. Did you measure some impact with big DWG's?
  I've also looked at sorting the refs, as already done in the encoder, and then use binary search. I'm not sure yet which approach to use. We already have the sorting routine, I'm just not using it with the decoder, as it will change all refs.
  And for the hashmap we would need a copyright assigned hashmap.

My merge is here: https://github.com/LibreDWG/libredwg/tree/benegon