benbaror / ne2001 Goto Github PK

Add in spiral arm contributions

As titled. I am starting a new branch on this.

1. We now have all the parameters in the ne2001_params.json,
   do we need the other json files?.
   In the longterm, definitely not. I thought it good to
   save them for now (and maybe for posterity).

2. It will be nice to have a script that converts the old fortran input files to the ne2001_params.json format and vice versa. I think you have all the component to do that in the io.py.
   I have a Notebook that does most of it. Could make
   a script too. Unfortunately, I did have to do some by-hand
   edits on a couple of the old files. So it isn't 100% automated..

3. We also need to decide what will be the main interface for the users. Will it be the ne2001_params.json, the old fortran input files or something else. Once we decide we can get rid of the other files to prevent confusion.
   I think it is better to have one file with all the parameters. Then if someone come with the old input file, there will be a script that will convert them to the new input format.

What do you think?
I think this is good

When running Travis

For some calculations, I might suggest that we include astropy units.

In particular, I have in mind using them for DM and distances.