ben-zen / uri-library Goto Github PK

View Code? Open in Web Editor NEW

30.0 30.0 13.0 38 KB

A Modern C++ URI library.

C++ 100.00%

uri-library's People

Contributors

Stargazers

Watchers

Forkers

dereckson berkus adevress databaseerror antmerlino janucaria ccf19881030 v1934 stephaniewang526 magdacisowska aeloong luozhiya hammurapi datoudaydayup

uri-library's Issues

Reorder warnings

Compiling with g++ g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0

src/uri.hh: In constructor ‘uri::uri(const char*, uri::scheme_category, uri::query_argument_separator)’:
src/uri.hh:655:8: warning: ‘uri::m_path_is_rooted’ will be initialized after [-Wreorder]
  655 |   bool m_path_is_rooted;
      |        ^~~~~~~~~~~~~~~~
src/uri.hh:654:17: warning:   ‘long unsigned int uri::m_port’ [-Wreorder]
  654 |   unsigned long m_port;
      |                 ^~~~~~
src/uri.hh:54:3: warning:   when initialized here [-Wreorder]
   54 |   uri(char const *uri_text, scheme_category category = scheme_category::Hierarchical,
      |   ^~~
src/uri.hh: In constructor ‘uri::uri(const string&, uri::scheme_category, uri::query_argument_separator)’:
src/uri.hh:655:8: warning: ‘uri::m_path_is_rooted’ will be initialized after [-Wreorder]
  655 |   bool m_path_is_rooted;
      |        ^~~~~~~~~~~~~~~~
src/uri.hh:654:17: warning:   ‘long unsigned int uri::m_port’ [-Wreorder]
  654 |   unsigned long m_port;
      |                 ^~~~~~
src/uri.hh:64:3: warning:   when initialized here [-Wreorder]
   64 |   uri(std::string const &uri_text, scheme_category category = scheme_category::Hierarchical,
      |   ^~~

uri-library lacks support of percent-encoded query value

I need to parse URIs which contain arbitrary characters in the query value. To be able to do this the URI library needs to be able to decode the percent-encoded value string.

Here is an example : http://a/b/?q1=question-mark%3f&q2=ampersand%26
The query parameters of this URI should result in these decoded parameter-name parameter-value pairs:
q1=question-mark?
q2=ampersand&

Use a real test library

This project should actually use GTest for really testing the code.

URI init with try-catch

How to keep uri after try-catch without empty constructor?

uri request;
try {
  request = uri(std::string(buf));
  auto requestParams = request.get_query_dictionary();
} catch (std::invalid_argument &e) {
  ...
}
request.get_path();

Following example is not working, I don't want to wrap whole logic into try-catch...

Incorrectly parsing of url without path

When attempting to parse: https://test.com:443

#include "uri.hh"
#include <iostream>

int main(int argc, char ** argv)
{
  uri test_uri("https://test.com:443");
  auto t = test_uri.to_string();
  cout << "server: " << test_uri.get_host() << " post: " << test_uri.get_port() << " new_url: " << test_uri.get_path() << " - " <<  t << std::endl;
  return 0;
}

The host and port are correctly set. However the m_path is not correctly set. It is set to //test.com:443

You can mitigate this issue by appending / to the url (e.g. https://test.com:443/). However the a uri should be parsed correctly without a path.

Checked Iterators: Test fails with "cannot dereference string iterator because it is out of range (e.g. an end iterator)"

Test.cc fails with the above message when it is compiled with:

cl /MDd /D_ITERATOR_DEBUG_LEVEL=1 test.cc

The failing test is this one:

uri no_host("file:/example.txt");

ben-zen / uri-library Goto Github PK

uri-library's People

Contributors

Stargazers

Watchers

Forkers

uri-library's Issues

Reorder warnings

uri-library lacks support of percent-encoded query value

Use a real test library

URI init with try-catch

Incorrectly parsing of url without path

Checked Iterators: Test fails with "cannot dereference string iterator because it is out of range (e.g. an end iterator)"

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent