bellerb / chess Goto Github PK

Check mate not working returning [0,0,0], forcing users to capture king.

EPG = '1b5k/7P/p1p2np1/2P2p2/PP3P2/4RQ1R/q2r3P/6K1 w - -'

Hi,

there is an error in the checkmate validation, but I cannot really understand the code to fix it properly, but the error is here:

https://github.com/bellerb/chess/blob/main/chess.py#L321

if k_pos[0] not in g_moves:
  if len(self.log) > 0 and self.log[-1][-1] is not '+':
      self.log[-1] += '+' #Check
  return [0, 0, 0]

I don't get why you check if self.log[-1][-1] is not '+'if this part of the code and some lines below are the only place that adds the '+' to the move.

You can test with the following EPD='4kb2/rpp1p3/6p1/6Np/3Q1B2/4P2b/PPP2PPP/RN1R2K1 w - -'
The winning move is d4 d8.
Roberto