Code Monkey home page Code Monkey logo

sentiment-bot's People

Contributors

antn avatar hiimbex avatar jamesmacfie avatar macklinu avatar peterblazejewicz avatar shermanhui avatar sloria avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

sentiment-bot's Issues

not enough emoji πŸ’™

proposed solutions:

❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️ ❀️
πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰ πŸŽ‰
πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™ πŸ’™
πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’― πŸ’―
πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ πŸ’ƒ

Permission for team mentions?

You can see from the comment posted in probot/probot#258 (comment) that the bot currently can't mention teams. As discussed in probot/probot#337, the app needs Read permission on Organization members.

What do you think about adding that to the app's permissions? I'm not thrilled that it's necessary, but I imagine this bot will often be used to mention teams.

Get human response to toxic people

For a repo or org, have a Slack team and channel to report toxic comments in
Perhaps even a way for a moderator to mark that the comment has been handled so that behavior-bot can remind the channel if something isn't handled within X amount of time

h/t @lee-dohm

Using the node-github accept header

So basically this bot depends on these changes: octokit/octokit.js#555. Right now I've simply replace it in my node_modules, but that won't work when this gets deployed, so I'm not sure what's the best option.

The only line I truly need from my PR is the accept header here. According to some of their docs I can add an accept header when I instantiate the GitHub API; unfortunately, probot does the work on that end.

Options:

  1. Update probot's node-github handling to allow additional accept headers
  2. Don't use context.github and authenticate through node-github directly in my bot and pin my branch in the package.json
  3. Beg @zeke to merge my PR πŸ˜†

Thoughts @bkeepers?

feature_request(message): More customizable sentiment-bot message

1. Summary

It would be nice, if user can customize this part of Sentiment Bot message:

Keep in mind, this repository uses the Contributor Covenant.

Now user can't change this text.

2. Argumentation

More customization β€” always good.

User can want to:

  1. use another message instead of Keep in mind, this repository uses the Contributor Covenant,
  2. using [**bold links**](http://example.link) instead of [**link**](http://example.link).

3. Example of expected behavior

If in config.yml:

sentimentBotReplyComment: |
  Please be sure to review the code of conduct and be respectful of other users. cc/ @Kristinita

  [**CODE_OF_CONDUCT.md**](https://<link to CODE_OF_CONDUCT>) for this repository.

sentiment-bot will use [**CODE_OF_CONDUCT.md**](https://<link to CODE_OF_CONDUCT>) for this repository. instead of Keep in mind, this repository uses the Contributor Covenant.

Thanks.

test(sentiment-bot): Example toxic messages

Examples from Perspective:

They are liberal idiots who are uneducated.

Climate change is happening and it's not changing in our favor. If you think differently you're an idiot.

They're allowed to do that. But if they act like assholes about, I will block them.

I think its a farce and stinks like a bathroom after 26 beers

My thoughts are that people should stop being stupid and ignorant. Climate change is scientifically proven. It isn't a debate.

Don't show CoC link if there isn't one

I thought

sentiment-bot/index.js

Lines 17 to 19 in 3b0aff3

if (repoData.data.code_of_conduct) {
codeOfConduct = Object.assign({}, repoData.data.code_of_conduct);
}

and

sentiment-bot/index.js

Lines 38 to 42 in 3b0aff3

if (codeOfConduct) {
comment = config.sentimentBotReplyComment + 'Keep in mind, this repository uses the [' + codeOfConduct.name + '](' + codeOfConduct.url + ').';
} else {
comment = config.sentimentBotReplyComment;
}

would handle this however, due to https://github.com/github/github/issues/73388 that's not true.

This is something I'll be fixing later this week for my team πŸ˜† crazy how everything is connected.

cc/ @benbalter @bkeepers for interesting things :)

question(docs): toxicity threshold

1. Summary

It would be nice, if sentimentBotToxicityThreshold key description will be more understandable.

2. Details

Sentiment Bot description:

*Required* toxicity threshold between 0 and .99 with the higher numbers being the most toxic
Anything higher than this threshold will be marked as toxic and commented on

What is β€œbeing the most toxic”?

Did I understand correctly that:

  • 0 β€” maximum words and phrases will be marked as toxic,
  • .99 β€” minimum words and phrases will be marked as toxic.

?

Or vice versa?

Thanks.

Needs documentation

I went to set up the bot for my own repos, but there was no documentation. :sad:

Would it be possible to add a README like the other behaviorbot plugins? πŸ˜„

Swap to standard linting

Re: behaviorbot/welcome#8 updating to standard linting, which means: in the package.json changing:

"test": "mocha && xo --extend eslint-config-probot"

to mocha && standard and removing the unnecssary dependecnies here:
"devDependencies": {
"eslint-config-probot": "^0.1.0",
"expect": "^1.20.2",
"localtunnel": "^1.8.3",
"mocha": "^3.4.2",
"xo": "^0.18.2"
},
"xo": {
"space": 2
},
(xo and the eslint one). Then installing standard with npm install --save-dev standard and then running standard --fix to lint all things standard.

You will probably also need to add to the package.json this:

"standard": {
    "env": [
      "mocha"
    ]
  },

so that our tests can operate without linting errors.

Then run npm test to make sure everything works! Let me know if you have any questions.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.