Code Monkey home page Code Monkey logo

peertube-plugin-creative-commons's People

Contributors

chocobozzz avatar frankstrater avatar phivk avatar rigelk avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

Forkers

klorydryk

peertube-plugin-creative-commons's Issues

Issues: insert HTML elements with plugin

Inserting elements on action:video-watch.video.loaded gets duplicated when clicking on a recommended video on the watch page

This new "hello world" plugin example from PeerTube shows how to inject/adapt HTML nodes, but it's unclear what the best way is to clear the element to prevent duplication or implement replacement of the node content. Is there a clean way to clear this injected element with another action?

https://framagit.org/framasoft/peertube/official-plugins/-/blob/master/peertube-plugin-hello-world/client/video-watch-client-plugin.js#L17

https://docs.joinpeertube.org/contribute-plugins?id=html-placeholder-elements

Inserting elements in HTML nodes that don't have an id attribute isn't very robust. Using a class selector works, but sometimes (on first load of watch page) it can't find the node by class (not there yet?)

Is there anything that we are missing when selecting the node with the class 'video-info-date-views'? Does it really need filter:internal.video-watch.player.build-options.result to work?

@Chocobozzz Could you please have a quick look at our code in master and give some pointers on possibly obvious things we are missing with these issues?

Adding custom license to the CC list

Hi,
As mentionned in the Add the Free Art License post on ideas.joinpeertube.org, in some case, more options would be usefull.
I work for a public organization affiliated to the French Ministry of Education.
Some of ours videos use CC licence, when others use custom licence.

What I suggest : add an additional option to the CC licence plugin, called "custom licence", which is customizable in the preference page of the plugin.

CC BY 4.0
CC BY-SA 4.0
CC BY-ND 4.0
CC BY-NC 4.0
CC BY-NC-SA 4.0
CC BY-NC-ND 4.0
CC0 1.0
Public Domain Mark 1.0
Free Art License
Custom licence

This "custom licence" would be a text field, where the admin of the instance could specify a text, and an url (optionnal).
In my case (public education organization), we would put "Conditions générales de vente et d'utilisation" which would redirect the user to https://www.reseau-canope.fr/conditions-generales-de-vente-et-dutilisation.html

Thanks to think about it, for our public needs, and maybe other one. Best regards.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.