Code Monkey home page Code Monkey logo

Comments (9)

FamousWolf avatar FamousWolf commented on June 20, 2024

Can you see if #189 fixes this issue for you?

from fal_securedownload.

chrissonntag avatar chrissonntag commented on June 20, 2024

I've tested it by checking out commit 8233513 and can confirm that downloads are now being initialized. But for some reason the file name of the respective file (to be downloaded) gets cut completeley and only the file extension remains. So i.e. if I try to download a file called Dummy.pdf it'll be sent to the browser as just "pdf". I've tested Chrome, Brave and Vivaldi.

from fal_securedownload.

FamousWolf avatar FamousWolf commented on June 20, 2024

@chrissonntag I can not reproduce this problem. How do you try to download the file? There are multiple ways in the backend, so maybe I missed one. Is this a clean TYPO3 installation or are there any other extensions installed?

from fal_securedownload.

chrissonntag avatar chrissonntag commented on June 20, 2024

@FamousWolf
I have tested it with 2 Typo3 instances. Both running with v11.5.14. The one is of one of our customers, the other one is a fresh installation only having fal_securedownload as 3rd party extension installed. The behaviour in both system is exactly the same.

How to reproduce:
Beside the common fileadmin folder create another storage wich is not public and upload any file at all. The folder in which the uploaded file lies does not even have to be restricted to any FE groups.
Download the uploaded file and recognize that only the extension is presented as full filename.

If you upload the exact same file or any other to the common fileadmin folder, the download works just fine.

from fal_securedownload.

FamousWolf avatar FamousWolf commented on June 20, 2024

@chrissonntag I tested it again in a clean TYPO3 11.5.14 instance and still wasn't able to reproduce it. I made a video of how I tested it. Can you see if you're testing it differently? https://youtu.be/RR6SRcakIxg

from fal_securedownload.

chrissonntag avatar chrissonntag commented on June 20, 2024

Like I said, I tested it with the version on commit 8233513. However it seems that the error had been fixed in the meantime (tested version v4.0.1). That's why I'm closing this issue. Thanks for your effort!

from fal_securedownload.

chrissonntag avatar chrissonntag commented on June 20, 2024

from fal_securedownload.

FamousWolf avatar FamousWolf commented on June 20, 2024

I think that was caused due to a bug fixed in 7eab76c. It's been merged today. Can you test it in the current master?

from fal_securedownload.

chrissonntag avatar chrissonntag commented on June 20, 2024

@FamousWolf I can confirm that your bug fix has solved the mentioned download problem. Filenames are being provided properly now.

from fal_securedownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.