Code Monkey home page Code Monkey logo

Comments (4)

stephangrass avatar stephangrass commented on September 24, 2024

Same error here.

from fal_securedownload.

joey-bolts avatar joey-bolts commented on September 24, 2024

Thanks for the ticket.

I might be able to look into this tomorrow or starting next week. Any PR would speed up a fix.

from fal_securedownload.

sdelcroix avatar sdelcroix commented on September 24, 2024

I confirm this issue with TYPO3 11.5.30, PHP 7.4 FPM and fal_securedownload 5.0.0

from fal_securedownload.

sdelcroix avatar sdelcroix commented on September 24, 2024

It is caused by string type hint for $combinedIdentifier argument in BeechIt\FalSecuredownload\Hooks\AbstractBeButtons::generateButtons() added with 5.0.0 version.

A quick fix could be in Hooks/DocHeaderButtonsHook::getButtons() :

  public function getButtons(array $params, ButtonBar $buttonBar): array
    {
        $buttons = $params['buttons'];

        if(is_null(GeneralUtility::_GP('id'))) return $buttons; // HERE THE QUICK FIX

        foreach ($this->generateButtons(GeneralUtility::_GP('id')) as $buttonInfo) {
            $button = $buttonBar->makeLinkButton();
            $button->setIcon($buttonInfo['icon']);
            $button->setTitle($buttonInfo['title']);
            $button->setHref($buttonInfo['url']);
            $buttons[ButtonBar::BUTTON_POSITION_LEFT][1][] = $button;
        }

        return $buttons;
    }

from fal_securedownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.