beanheadza / tradeassistant Goto Github PK

Use CommandsUtil.ClosestMatchingEntity to match the text the user enter to a store name. By using the util we get partial matching as well.

Split explain into two commands: explain and sendexplain. That way we don't make the command too complex with two optional parameters (whoToSendTo and storeName)

When adding items for sale, don't add items that are just intermediate items such as Iron Saw Blade. The Iron Saw Blade only gets used and made by smelters.

This will get tricky for items like Leavened Dough where it's an itermediate item, but it still counts as a food item.

And let people config the break points and the individual markups

Add warning about recipes that will make you a loss when running /ta update

Since Version 10, most players are limited to having one plot and multiple stores on them.

As I understand most users would prefer to be able to use the command to the closest store on the current plot.

I would suggest to have a confirmation dialog for the user, asking if the nearest store is the correct one and apply the command after confirmation.

It appears that the 0.1.7 release affected the ability to price a number of things. Another example is when doing cooking, it's often easier to set a buy order of Raw Meat, which would be used to calculate all prices instead of adding carcasses, but that no longer seems to work. Additionally, some items won't price, like crushed slag with mining.

A couple of things to consider:

• Add some profiling information to see which steps take long to run

• I have a suspicion that ModuleContext from the DynamicValue is what's taking so long. Perhaps caching it at the start would be helpful

• It would also help the server if the updates were not on the main thread, but instead on a low priority thread in the background

Firstly, this mod is amazing and something I've been looking for for some time! Absolutely fantastic work @BeanHeaDza

High volume, low cost commodities like crops may be 10% profit while furniture or one time purchases you may want a higher percentage. I'm suggesting the ability to set different profit margins for specific items, or possibly category.

I'm very happy to work with you in coding new features as well if wanted.

Installation instructions and
Please tell me how to set it up after installation.

Can all users use it if I just install the mode?