bcoin-org / bsock Goto Github PK

Hi, I want to use bclient in a react app, in order to do so I need es5 npm packages: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

It's odd that Socket inherits from EventEmitter but implements its own event cycle with bind

https://github.com/bcoin-org/bsock/blob/master/lib/socket.js#L19

https://github.com/bcoin-org/bsock/blob/master/lib/socket.js#L837-L887

I raise this issue because I was mistakenly using on and not bind so events we're firing, but there is something odd about the implementation as such, its managing two lifecycles one on the Socket, one internally on Events.

Perhaps as a solution, on could proxy to bind when sensible to maintain a consistent event emitter implementation

Current socket.io vendor in test is probably outdated, it still relies on new Buffer so if you run tests it show deprecation warnings. At some point node will probably remove constructors.

I am leaving this as issue right now, so we don't forget to address this.