bbopt / solar Goto Github PK

Hi,

First, thank you very much for this simulator; it is very beneficial for testing DFO methods.

A wrong return code seems to be provided when running the following code.

./bin/solar -h  # or ./bin/solar -h <pb_id>
echo $?

Indeed, the value one is returned. Is it intended or is it a small bug in the simulator?

Cheers,
Tom.

Though SOLAR does not support GNU-style long options (with two leading hyphens), it should probably interpret them as unknown options rather than as non-option arguments:

$ ./solar --help
Display help for Problem "--help":

This problem id is invalid

Perhaps using an option-parsing library would be advisable.

Hi Sebastien,

Generally Makefiles are in the root of the project, which allows you to type make without further changing directories. In addition, some of the Makefile's variables, such as COMPILATOR, COMPILATOR_OPTIONS, etc., differ from the standard names. This is inconveniencing for users accustomed to CXX, CXXFLAGS, etc., when overriding the flags on the command line. Finally, I see that the dependencies are manually specified in the Makefile. There is a way to automatically generate them with gcc's -M* flags.

If you give me the go-ahead, I can prepare a PR addressing these issues.