bazzline / php_component_curl Goto Github PK

There is an PHP-Doc issue in the method Builder::withTheRawOption.
While PHP-Doc only allows to pass strings as values, it should be of type mixed.

E.g. when you are passing CURLOPT_HTTPHEADER which as an array as value option.

psr-7 is out.

Does it make sense to write a dedicated Builder dealing with psr 7 request and returning a psr 7 response?

Hi Stev,

I've just found that there is an issue with sending post requests with json as content type using this component.

The first problem is the fact that default header

'application/x-www-form-urlencoded; charset=UTF-8'

is always set in

https://github.com/bazzline/php_component_curl/blob/master/source/Request/RequestFactory.php#L80

so even if you use asJson() method in builder it will have two different content type headers.

'application/json'
'application/x-www-form-urlencoded; charset=UTF-8'

And because the default one is the last one then it is overriding json content type.

Lastly if request is of json type then ConvertJsonToArrayBehaviour is called after performing the request.

But there at line https://github.com/bazzline/php_component_curl/blob/master/source/ResponseBehaviour/ConvertJsonToArrayBehaviour.php#L24

json_encode function is triggered instead of json_decode.

As a workaround user can call Builder::reset(true) method after builder create method to just have this headers empty and then use asJson to make the valid content type.

But there is no way to fetch the correct response content since original json content is encoded once again after fetchin instead of json_decodeing.

Regards
Luke