Code Monkey home page Code Monkey logo

Comments (3)

ahumesky avatar ahumesky commented on August 10, 2024 1

I'm looking at removing this ACL altogether

from rules_android.

ahumesky avatar ahumesky commented on August 10, 2024

I think this might be an issue with the ACL system in the rules, rather than a problem with resource processing itself.

If you're set up for it, does it work if you change this line to propagate_resources = True:

rules_android/rules/aar_import/impl.bzl

Line 158 in 39aa253

propagate_resources = _acls.in_aar_propagate_resources(str(ctx.label)),

from rules_android.

ahumesky avatar ahumesky commented on August 10, 2024

Yes I think this is because under bzlmod, label syntax changes a bit and they look like @@rules_jvm_external~~maven~maven//:androidx_core_core, and ACL resolution in the android rules doesn't fully parse labels with bzlmod:

rules_android/rules/acls.bzl

Lines 284 to 300 in 39aa253

# Labels with workspace names ("@workspace//pkg:target") are not supported.
# For now, default external dependency ACLs to True to enable rollout features for all
# external users. See https://github.com/bazelbuild/rules_android/issues/68
# Note that this only affects Bazel builds with OSS rules_android.
if fqn.startswith("@") and not fqn.startswith("@//") and not fqn.startswith("@@//"):
return True
# "@//" is the same as the main workspace. It's not completely accurate to treat these as
# absolute labels, because "@//" from within an external repository refers to the main
# workspace, and "//" from within an external repository refers to labels within that
# repository, but this should be fine for ACL resolution.
if fqn.startswith("@//"):
fqn = fqn[1:]
# "@@//" refers to the canonical name of the main repository.
if fqn.startswith("@@//"):
fqn = fqn[2:]

from rules_android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.