bausmeier / node-bitx Goto Github PK

Would it be possible to add pair parameter as option to getTicker, getOrderBook, getTrades and getOrderList, rather then using the pair from constructor?

Not possible to pass optional parameters (post_only, base_account_id, counter_account_id) for post order methods

As per BitX API documentation, getBalance method should not require the argument asset

it looks to me that "this" used in the prototype may have a problem addressing the right context.
Please check and you may consider either including the functions in the main function/constructor (without prototype) or use _.bindAll(this) in the constructor

callback is called in the try statement in BitX.js at line 72.
If the callback function throws an exception, then callback is executed again in catch.

Possible solution

       try {
          response = JSON.parse(response);
        } catch (err) {
          callback(err);
          return;
        }
        if (response["error"]) {
            callback(new Error(response.error));
          } else {
            callback(null, response);
          }

Are you aware of a way to get a function triggered when the ticker updates, instead of repeatedly polling the api? I was trying to find the websocket that the html5 market uses but couldn't find it..

Following error is returned
{ [Error: Parse Error] bytesParsed: 0, code: 'HPE_INVALID_CONSTANT' }

Code:

var BitX = require('bitx');
exports.getr = function(req, res){
    var vbitx = new BitX();
    vbitx.getTrades(function(err,result){
        console.log(err);
    });
};

Can you implement the method getOrder (Get an order by its id).
Thanks!

get all tickers is not implemented

https://api.mybitx.com/api/1/tickers

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: BitX error 504

Any ideas?

Parameter pair for getOrderList should be optional and should not be set to a default value when not specified