Calculation Method for Morocco about adhan-js HOT 13 CLOSED

This is my actual code :

const adhan = require("adhan");
const moment = require("moment");

// Casablanca
const coordinates = new adhan.Coordinates(33.5731,-7.5898);


// Params
const params = adhan.CalculationMethod.Other();
params.fajrAngle = 19;
params.ishaAngle = 17;
params.madhab = adhan.Madhab.Shafi;

getPrayers = date => {
  const prayerTimes = new adhan.PrayerTimes(coordinates, date, params);
  const result = {};
  Object.keys(prayerTimes).forEach(e => {
    if (typeof prayerTimes[e] != "function")
      result[e] = moment.utc(prayerTimes[e]).format("HH:mm");
  });
  return result;
};

const monthResult = [];

let tempdate = new Date(2020,4,1)

for (var i = 1; i <= 30; i++) {

  const dailyResult = getPrayers(tempdate);
  monthResult[moment.utc(tempdate).format("DD_MM")] = dailyResult;
  tempdate = moment(tempdate)
    .add(1, "days")
    .toDate();
}

Object.keys(monthResult).forEach(e=>{
    console.log(e, monthResult[e].fajr,monthResult[e].sunrise,monthResult[e].dhuhr,monthResult[e].asr,monthResult[e].maghrib,monthResult[e].isha);
    // console.log(`${monthResult[e].isha} - ${monthResult[e].maghrib} - ${monthResult[e].asr} - ${monthResult[e].dhuhr} - ${monthResult[e].sunrise} - ${monthResult[e].fajr} - ${e}`)
})
// console.log(result);

And those are the params I used, based on some research on the internet

// Casablanca
const coordinates = new adhan.Coordinates(33.5731,-7.5898);


// Params
const params = adhan.CalculationMethod.Other();
params.fajrAngle = 19;
params.ishaAngle = 17;
params.madhab = adhan.Madhab.Shafi;

from adhan-js.

This is the actual result :

And this is the expected result:

from adhan-js.

Does anyone have any idea why there are differences ?

from adhan-js.

@kafiil A quick thing to note on the discrepancies. I see you're listing the prayer times for the month of May however when I go to http://www.habous.gov.ma/prieres/index.html I see that it actually goes from April 25 to May 23 (the month of Ramadan). Where did you get the remainder of the month of May?

from adhan-js.

I think we can gather all the prayer times for a full year by using the wayback machine http://web.archive.org/web/20180901000000*/http://www.habous.gov.ma/prieres/index.html

from adhan-js.

@z3bi Thanks for your reply.
I Used this to get the official times http://www.habous.gov.ma/fr/horaire-priere.html
In that page you can select to month (Georgian) you wish to view and the city and you get the data.

Also, and because I never could calculate accurate times I made and api with scrapped data from this website.

You can view it here, it has a swagger that you can use to test it.

You don't need the wayback machine, the api gives you whatever you need, I can provide the data for the whole year, but for any city ?

from adhan-js.

I also made this small react app ( that looks ugly right now ).

If I could calculate the times in Morocco with accuracy, I wouldn't need the api.

from adhan-js.

I Used this to get the official times http://www.habous.gov.ma/fr/horaire-priere.html
In that page you can select to month (Georgian) you wish to view and the city and you get the data.

Thats perfect. So we just need to pick a city (like Marrakesh) and get the prayer times for 1 day of each month and create JSON file following this format https://github.com/batoulapps/adhan-js/blob/master/Shared/Times/Dubai-Gulf.json

That will allow us to recreate the prayer times with accuracy.

from adhan-js.

https://maroc-salat.herokuapp.com/prayer?cityId=80&day=1&lang=fr-fr

This is the data for Marrakech for each first day if the month for the whole year.

I can do some transformation to make it in the required format

from adhan-js.

@z3bi I need your help to complete the JSON,
What I am supposed to put in the source array apart from the url of the official website ?

Please let me know when you're available for a chat.

from adhan-js.

That’s where I generally copy and paste the original times from the website. JSON doesn’t support comments so I made it an array of strings to reference.

from adhan-js.

I am also not. sure about the highLatitudeRule, I didn't change it in my CalculationMethod.

from adhan-js.

I added the requested file to my branch, it's now part of the pull request.

from adhan-js.