Code Monkey home page Code Monkey logo

Comments (6)

z3bi avatar z3bi commented on September 27, 2024

You want to adjust sunset separately from Maghrib? We don't return a sunset time, just a Maghrib time. Can you explain what is the issue you're trying to solve?

from adhan-js.

meypod avatar meypod commented on September 27, 2024

I'm very sure you do return a sunset time, because I'm using it, maybe it was added at some point ?

from adhan-js.

meypod avatar meypod commented on September 27, 2024

and I think I have explained why I need to adjust it, and it's the only remaining time that I cannot adjust

from adhan-js.

z3bi avatar z3bi commented on September 27, 2024

You're right we do return a sunset time. However this was done as a convenience in case you needed to access it and is not part of the standard prayers we return. I am hesitant to include support in other things like being part of adjustments.

from adhan-js.

meypod avatar meypod commented on September 27, 2024

I don't see why not given it needs only 2-4 lines of code to support like the other times it support

And there's no pressure to do so, I can patch my packages locally to do what I need them to do
But I thought since the other times are there, it would be nice for this one to have as well (i have found a need, some one else may do as well)

from adhan-js.

meypod avatar meypod commented on September 27, 2024

maybe add it but also add a jsdoc to the sunset time and mention that while It's available It's not what people should normally be using ? if that's what you mean

from adhan-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.