Comments (6)
You want to adjust sunset separately from Maghrib? We don't return a sunset time, just a Maghrib time. Can you explain what is the issue you're trying to solve?
from adhan-js.
I'm very sure you do return a sunset time, because I'm using it, maybe it was added at some point ?
from adhan-js.
and I think I have explained why I need to adjust it, and it's the only remaining time that I cannot adjust
from adhan-js.
You're right we do return a sunset time. However this was done as a convenience in case you needed to access it and is not part of the standard prayers we return. I am hesitant to include support in other things like being part of adjustments.
from adhan-js.
I don't see why not given it needs only 2-4 lines of code to support like the other times it support
And there's no pressure to do so, I can patch my packages locally to do what I need them to do
But I thought since the other times are there, it would be nice for this one to have as well (i have found a need, some one else may do as well)
from adhan-js.
maybe add it but also add a jsdoc to the sunset time and mention that while It's available It's not what people should normally be using ? if that's what you mean
from adhan-js.
Related Issues (20)
- Prayer Ending Times HOT 1
- Understanding the functionality of nextPrayer and currentPrayer HOT 2
- Moon Phases?
- Wrong time returned HOT 1
- [suggestion]: Use `const enums` for some constant variables
- time difference for asr on Turkey HOT 1
- The use of Temporal HOT 2
- [suggestion]: Add 'Imsak' Timings HOT 4
- Host the javascript on cdnjs or similar HOT 1
- Turkish Diyanet times for Netherlands gives wrong for yatsi time
- Reason for using sth like moment.js HOT 2
- Taking elevation into account for prayer times HOT 1
- Considering elevation for Salah times HOT 21
- TypeError: Cannot read properties of undefined (reading 'getTime') HOT 1
- Prayer times are wrong(?) HOT 16
- The possibility of adjusting the midnight time HOT 1
- Calculation is returning prayer times for next day instead of "today" HOT 3
- Getting Default Calculation Method for Location
- Wrong times HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adhan-js.