bathlamos / programmers-playing-cards Goto Github PK

The readme has no link to KickStarter. It would help complete the loop of traffic this gets to help both the fund-raising, and the hype.

The hearts 7 hast the wrong suit, it reads diamonds but should be hearts, right?

I think pho and haze need looking at as I do not believe they are correct

More than one person has requested cards made in a plastic-like material. Need to investigate and get quotes.

What is the maximum number of lines that a code example can be? Some languages are naturally more "verbose" than others. I am looking at the Java example and would like to provide a more cleanly implemented class definition, but am finding myself writing > 9 lines.

public class Card {
    private final int rank;
    private final Suit suit;
    public enum Suit {DIAMONDS}
    static {
        new Card(8, Suit.DIAMONDS);
    }
    public Card(int rank, Suit suit) {
        this.rank = rank;
        this.suit = suit;
    }
}

What is the maximum number of lines that will be accepted?

Currently is {rank} of {rank} rather than {rank} of {suit}

I'm not sure how Haskelly the example is, I've come up with a new one but it's possibly a bit longer but i feel that you should show currying in the little example :) What are the constraints we're working towards? what are your views on what can be left out?

type Suit = String
type Rank = Int

data Card = Card{
  rank :: Rank,
  suit :: Suit }
  deriving(Show)

newCard :: Rank -> Suit -> Card
newCard = \r -> \s ->
    Card{ rank = r, suit = s }

card :: Card
card = newCard 4 "Hearts"

I was a big supporter of this project till i saw that, its disappointing

Based on the code in the Clubs folder, this should be C++, not Coffeescript