Comments (11)
One last addendum while I'm here... I'm not a total Git Flow fan but I do like some of their structure - the biggest one being using a develop
branch for your primary development and retaining master
for releases. If you're amenable I would love to work with you on that.
from stravaphp.
@MGatner https://github.com/basvandorst/StravaPHP/releases/tag/2.0.0
If any older version requires a support branch we can do so manually. I'm not expecting many requests to that end, honestly.
from stravaphp.
Starting with static analysis, #76
from stravaphp.
Updating unit tests, #78
from stravaphp.
Guzzle 7 compatibility, #79
from stravaphp.
@djjavo @vredeling Since we're almost over the basics of compatibility... what are your thoughts on next steps for this library? A couple of ideas I would be interested in:
- Drop unsupported versions of PHP (< 7.4). This would allow the next major version to add a bunch of new PHP features (most notably: property types)
- Implement entities. Instead of returning everything as an array of data, make it into an actual PHP class with expected types. I haven't worked with the API yet so maybe things aren't as consistent as I'm expecting, but it would be a big boost for working with the library.
from stravaphp.
@djjavo @vredeling Since we're almost over the basics of compatibility... what are your thoughts on next steps for this library? A couple of ideas I would be interested in:
- Drop unsupported versions of PHP (< 7.4). This would allow the next major version to add a bunch of new PHP features (most notably: property types)
- Implement entities. Instead of returning everything as an array of data, make it into an actual PHP class with expected types. I haven't worked with the API yet so maybe things aren't as consistent as I'm expecting, but it would be a big boost for working with the library.
I'm not ready to drop php7 support just yet on the existing branches, as I don't know what systems the current users of this lib are working on. But I'm quite kind to make the jump to 8 myself.
Entities, would be useful as long as they exactly mimic the models in the current API. See: https://developers.strava.com/docs/reference/#api-models
With regards to git flow, I'm totally on board with using that. And for its shortcomings, at least it is a well known standard.
from stravaphp.
PHP 7.4 has security support through December. I'm proposing ^7.4 || ^8.0
from stravaphp.
With regards to git flow, I'm totally on board with using that
Great! I see there is an old develop
branch already - that will need to be brought up to speed:
git switch master
git pull
git sw develop
git reset --hard master
git push -f
Then from the repo settings you can change develop
to be the default branch:
from stravaphp.
Hey guess what... I don't have sufficient permissions to change some essentials like the default branch. Contacting @basvandorst about that.
from stravaphp.
@vredeling when do you think we could get a new release of the work so far? The Guzzle 7 piece is still blocking most current PHP version.
from stravaphp.
Related Issues (20)
- getAthleteActivities is buggy when using parameters
- getResponse doesn't throw, it already catches HOT 3
- PHPUnit tests fail when running locally HOT 2
- Laravel 8 incompatibility HOT 6
- Can you do a point release? HOT 5
- Where is autoload.php HOT 2
- Upload gpx file failed HOT 1
- Wrong scopes in README.md code examples HOT 1
- GitHub Link Broken HOT 3
- Scrutinizer HOT 3
- Setup Packagist for automatic updates HOT 9
- Webhook Subscriptions HOT 2
- Fix tests after type hints HOT 1
- getSegmentLeaderboard not working HOT 5
- Having trouble getting OAuth2 to work and missing refresh token HOT 7
- Get "Required option not passed: "access_token"" message, when try to exchange token second time.
- get required
- Issue with refresh page: Required option not passed: "access_token"
- How to setup new access token when working on one client object?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stravaphp.