Laravel 8 incompatibility about stravaphp HOT 6 CLOSED

This will need to happen eventually anyway. So yes, let's do a quick scan of the outdated code so we have a sense of the scope. Looks quite involved at first glance.

from stravaphp.

The diff might look very big but 95% of Guzzle users will be able to upgrade without modification. Please see the upgrade document that describes all BC breaking changes.

It seems like the diff from 6.x to 7 looks large, but the actual changes to the implementation will be small - we might not even need any.

Out of the upgrade guide linked above, as the only main method used in the codebase is request() I can only see the following as changes that may impact StravaPHP:

• Request option exception is removed. Please use http_errors.
• Request option save_to is removed. Please use sink.
• The get, head, put, post, patch, delete, getAsync, headAsync, putAsync, postAsync, patchAsync, and deleteAsync methods are now implemented as genuine methods on GuzzleHttp\Client, with strong typing. The original __call implementation remains unchanged for now, for maximum backwards compatibility, but won't be invoked under normal operation.

from stravaphp.

The only issue I am seeing so far is on the getRouteAsGPX and getRouteAsTCX methods as request() should now return a ResponseInterface, whereas these apparently return a String.

from stravaphp.

I'm using this library with Drupal exclusively and Drupal core 8 and 9 are using Guzzle 6. The upgrade to Guzzle 7 is postponed to Drupal 10. That will be released somewhere in the second half of 2022.
I can merge and review your MRs but I don't see myself putting a lot of effort in porting it to Guzzle 7 right now. I'm happy to accept patches though. And in the meantime I propose we use a different branch and separate version numbers for tagging the Guzzle 7 compatible releases of stravaphp. We could maintain 2 separate versions of the code base if necessary so long as the code doesn't differ all that much.

from stravaphp.

@djjavo I've created a separate guzzle7 branch and updated packagist. You can require basvandorst/stravaphp:^dev-guzzle https://packagist.org/packages/basvandorst/stravaphp#dev-guzzle7
Hope that will suffice for now.

from stravaphp.

@djjavo The Drupal upgrade path came earlier than expected. So I'm going to merge this into a 2.x release when I finally get around to fixing #21.

from stravaphp.