baskapteijn / vs-ftp Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 173 KB

A Very Small FTP Server focused on simplicity and portability.

License: GNU General Public License v3.0

CMake 1.03% C 91.95% Shell 7.02%

c ftp

vs-ftp's People

Contributors

Stargazers

Watchers

vs-ftp's Issues

Add arduino (esp) support

Might require another filesystem implementation. Certainly another main entry section. Need to investigate.

Linux program DNS resolve and use inet_aton

In the main of the Linux sources it might be nice to do some DNS resolving on the IP(4) argument.

And look into inet_aton for IP4 string to binary conversion.

Add connection timeout

Timeout when not received or transmitted >= xx minutes. Where xx minutes should be configurable (config.h).

Make sure to check ALL send and receive functions for sockets.

Merge abs path file and dir functions

Let it determine if it's a file or a dir and return abspath.

Maybe even merge is relative path and abs path checks into 1 function if possible.

Problem with trailing slash for root dir

$ ./vs-ftp 172.16.16.107 2021 /src/yquake2/
2020-07-15_16:57:12 vsftp_server.c[244]: Initializing server
2020-07-15_16:57:12 vsftp_server.c[261]: Starting server
Server handler failed with error -1

On branch: staging/baskapteijn/add_size_cmd
On commit SHA: ddfaacf

Rewrite nlist to list

Only dir and read flags supported so may not be much more code or complexity. It does make it more useful for gui clients. Need to investigate.

Investigate: print root as '/', do not print the "real" path prefix

For security reasons, probably better.

SYS suggests default binary mode while server starts default ascii mode

$ pftp 172.16.16.107 2021
Connected to 172.16.16.107.
220 Service ready for new user.
Name (172.16.16.107:bas): anonymous
230 User logged in, proceed.
Remote system type is UNIX.
Using binary mode to transfer files.
ftp>

On branch: staging/baskapteijn/add_size_cmd
On commit SHA: ddfaacf

Use safe(er) string functions as much as possible

strnlen i.o. strlen f.e.

Add windows support

Investigate if a codebase can be created that 1:1 allows it to be run on linux and windows.

Add asserts for paths that can only be taken in case of a programming error

This will increase code coverage since it allows for removing some more lines of code and replacing it with a simple branch.

Keep the assertion check active in release!

Make handling of client part transfer socket part of server?

Just investigate if we can unify this, or even simplify it with the current transfer calls.

Use local time for logging

Currently universal time is used. Might be nicer to use local time.

Disconnect client during RETR (transfer) will hang the server

master, commit 5f33c39.

Client side (manual abort):

--2020-07-24 09:07:39--  ftp://82.161.203.4:2021//baseq3/pak0.pk3
           => ‘pak0.pk3’
Connecting to 82.161.203.4:2021... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD (1) /baseq3 ... done.
==> SIZE pak0.pk3 ... 479493658
==> PASV ... done.    ==> RETR pak0.pk3 ... done.
Length: 479493658 (457M) (unauthoritative)

pak0.pk3                                               9%[=========>                                                                                                            ]  41,17M  3,35MB/s    eta 1m 53s ^C

Server side:

$ tail -f 2020-07-24_07:05:27.log
2020-07-24_07:07:39 vsftp_server.c[201]: Received command from client: TYPE I
2020-07-24_07:07:39 vsftp_server.c[214]: Command handled successfully
2020-07-24_07:07:39 vsftp_server.c[201]: Received command from client: CWD /baseq3
2020-07-24_07:07:39 vsftp_server.c[214]: Command handled successfully
2020-07-24_07:07:39 vsftp_server.c[201]: Received command from client: SIZE pak0.pk3
2020-07-24_07:07:39 vsftp_server.c[214]: Command handled successfully
2020-07-24_07:07:39 vsftp_server.c[201]: Received command from client: PASV
2020-07-24_07:07:39 vsftp_server.c[126]: Socket 6 on port 40000 ready for connection...
2020-07-24_07:07:39 vsftp_server.c[214]: Command handled successfully
2020-07-24_07:07:39 vsftp_server.c[201]: Received command from client: RETR pak0.pk3

Hangs (or even crashed).

Add readme.md link to doxygen

See f.e. https://github.com/adafruit/Adafruit_Si7021

Also note the introduction page of the doxygen report.

Server gone after a while

Server seems to disconnect/kill itself after a while. Possibly socket timeout?

baskapteijn / vs-ftp Goto Github PK

vs-ftp's People

Contributors

Stargazers

Watchers

vs-ftp's Issues

Recommend Projects

Recommend Topics

Recommend Org