basilfx / arduino-commandline Goto Github PK

I've been working with your command line code. Thanks for posting this.

I noticed a peculiarity regarding the history. It took me a while to understand that you are using a character from an escape sequence for the up and down arrows. As a result, the escape sequence is echoed to the screen briefly.

It would be nice to filter out the escape sequence so it does not appear in the serial stream.

possibility to enable and use notification about command not found

#ifdef COMMAND_NOT_FOUND_MESSAGE
    if (!success) {
       this->serial.println(COMMAND_NOT_FOUND_MESSAGE);
    }
#endif

useful for command history implementation(like in Linux console):
(for last 5 or 10 commands)

#define KEYCODE_UP 65
#define KEYCODE_DOWN 66
/**************************/
case KEYCODE_UP:
  if (length > 0) {
    // Move pointer
    length = 0;
    this->serial.write("\33[2K\r");
  }
break;
case KEYCODE_DOWN:
  if (length > 0) {
    // Move pointer
    length = 0;
    this->serial.write("\33[2K\r");
}
break;

and this future must have possibility to be enabled like plugin from #define