baseflow / flutter-google-api-availability Goto Github PK

🏗 Enhancement Proposal

The plugin architecture should be transitioned to a federated architecture to be in line with Google's stance on plugin architectures.

Pitch

Even though this plugin only considers Android, adhering to the newest standards will make the project more approachable for developers that have worked with Flutter Plugins before. Additionally, when running the plugin on a different platform, the Android code can be pruned.

Platforms affected (mark all that apply)

• 📱 iOS
• 🤖 Android

🚀 Feature Requests

This is a request to add support for null safety to package:google_api_availability.
We depend on your awesome package, so would be great to have null safety enabled.

Contextualize the feature

The Dart/Flutter team already encourages publishing the migrated packages: See this blog post.

Describe the feature

See the migration guide for details about enabling null safety.

Platforms affected (mark all that apply)

• 📱 iOS
• 🤖 Android

🏗 Enhancement Proposal

The plugin architecture should be transitioned to a federated architecture to be in line with Google's stance on plugin architectures.

Pitch

Even though this plugin only considers Android, adhering to the newest standards will make the project more approachable for developers that have worked with Flutter Plugins before. Additionally, when running the plugin on a different platform, the Android code can be pruned.

Platforms affected (mark all that apply)

• 📱 iOS
• 🤖 Android

It is not updated on flutter plugin store it shows 3.0.1 but in github you told 3.0.2

🏗 Enhancement Proposal

Resolve these code deprecation warnings:

\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:11: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
^
\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:12: warning: [deprecation] ViewDestroyListener in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.ViewDestroyListener;
^
\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:13: warning: [deprecation] FlutterNativeView in io.flutter.view has been deprecated
import io.flutter.view.FlutterNativeView;
^
\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:58: warning: [deprecation] Registrar in PluginRegistry has been deprecated
public static void registerWith(Registrar registrar) {
^
\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:63: warning: [deprecation] ViewDestroyListener in PluginRegistry has been deprecated
registrar.addViewDestroyListener(new ViewDestroyListener() {
^
\google_api_availability_android-1.0.0+1\android\src\main\java\com\baseflow\googleapiavailability\GoogleApiAvailabilityPlugin.java:65: warning: [deprecation] FlutterNativeView in io.flutter.view has been deprecated
public boolean onViewDestroy(FlutterNativeView view) {

                               ^

6 warnings

Pitch

It will prevent breaking aplications when updating other flutter and dart packages, even flutter or dart themselves.

Platforms affected (mark all that apply)

• 📱 iOS
• 🤖 Android

Check if issue template can dictate a status.
Simplify PR- and issue template using flutter templates as reference

🐛 Bug Report

This library did not follow proper semver when it updated to AndroidX. Version 1.0.5 was updated to AndroidX and this is a breaking change yet the previous version was 1.0.4!

This could be an even bigger problem if this library is used as a transitive dependency from another library (as it was in my case) as it is not obvious that this library is the issue.

I was able to work around this issue by doing the following in my pubspec.yaml:

dependency_overrides:
  google_api_availability: 1.0.4

Expected behavior

I should be able to put google_api_availability: ^1.0.0 in my pubspec.yaml and rely on that any versions within 1.0.x will not break me. This is proper semver and Dart's versioning relies heavily on libraries following semver. The proper version update for the AndroidX compatible release should have been 1.1.0. This would have ensured that only people who manully updated to ^1.1.0 would get the breaking change. To see an example of how to do this, look at the cloud_firestore changelog.

Reproduction steps

Put google_api_availability: ^1.0.0 in a project that has not been updated to AndroidX. You will get errors when it tries to multidex. Something like:

Execution failed for task ':app:transformClassesWithMultidexlistForRelease'.
> com.android.build.api.transform.TransformException: Error while generating the main dex list.

Configuration

A Flutter project that is not updated to AndroidX and uses multidex.

Version: 1.0.5

Platform:

• 📱 iOS
• 🤖 Android

🐛 Bug Report

I can't upgrade the latest Gradle plugin version to (>3.2.0) because of this plugin. Which in turn leaves me unable to use the new app format (Android App Bundle). This is because this plugin expects kotlin plugin to be at version 1.2.71. For the new Gradle plugin the kotlin version must be at least 1.3.0.

Expected behavior

the app should compile

Reproduction steps

add this plugin (or for instance geolocator, which has this as a dependency) and allow Android Studio to upgrade to the latest Gradle.

Configuration

Android studio version 3.3 on windows, flutter updated to latest version

Version: 1.0.4

Platform:

• 📱 iOS
• [X ] 🤖 Android

🚀 Feature Requests

Would it be possible for you to also return a version of Google Play Services running on the device? This info is needed in order to prompt the user to update it in case it does not support needed functionality.

Contextualize the feature

Describe the feature

Platforms affected (mark all that apply)

• 📱 iOS
• 🤖 Android

🐛 Bug Report

I'm facing this error trying to build my Flutter project for iOS with "flutter build ios" command:

Building com.*******.mobile for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: *********
Running pod install... 2.0s
Starting Xcode build...
Xcode build done. 24.9s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **

Xcode's output:
↳
/Users/dev/Documents/flutter/.pub-cache/hosted/pub.dartlang.org/google_api_availability-1.0.2/ios/Classes/GoogleApiAvailabilityPlugin.m:2:9: fatal error: 'google_api_availability/google_api_availability-Swift.h' file not found
#import <google_api_availability/google_api_availability-Swift.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
/Users/dev/Documents/flutter/.pub-cache/hosted/pub.dartlang.org/geolocator-2.0.1/ios/Classes/GeolocatorPlugin.m:2:9: fatal error: 'geolocator/geolocator-Swift.h' file not found
#import <geolocator/geolocator-Swift.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Encountered error while building for device.

This is the output of flutter doctor:

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.7.3, on Mac OS X 10.13.2 17C88, locale en-BG)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.io/setup/#android-setup for detailed instructions).
If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
[✗] Android Studio (not installed)
[!] IntelliJ IDEA Ultimate Edition (version 2017.2.5)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Connected devices
! No devices available

This is how my pubspec.yaml file looks like:

name: ****
description: ***

version: 1.0.0+1

environment:
sdk: ">=2.0.0-dev.68.0 <3.0.0"

dependencies:
flutter:
sdk: flutter
intl: 0.15.7
cupertino_icons: ^0.1.2
http: 0.11.3+17
shared_preferences: 0.4.2
google_api_availability: ^1.0.2
geolocator: ^2.0.1

dev_dependencies:
flutter_test:
sdk: flutter

flutter:
uses-material-design: true

The SWIFT_VERSION from Xcode is 4.0. Any help will be very much appreciated.

Version: 1.0.2

Platform:

• 📱 iOS
• 🤖 Android

🐛 Bug Report

I copy-past this line of code from your package Readme page:

GooglePlayServicesAvailability availability = await GoogleApiAvailability().checkGooglePlayServicesAvailability();

But I immediately get the error:

The class 'GoogleApiAvailability' doesn't have a default constructor. Try using one of the named constructors defined in 'GoogleApiAvailability'.

Version: 2.0.4

Platform:

• 🤖 Android

🔙 Regression

The plugin shows a error when being started in a background service.
This seems to be related to the V2 embedding.

Old (and correct) behavior

No crash on V1 embedding.

Current behavior

2020-03-31 22:30:26.265 15821-15821/com.mynextbase.connect E/MethodChannel#flutter.baseflow.com/google_api_availability/methods: Failed to handle method call
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getPackageName()' on a null object reference
        at com.google.android.gms.common.GooglePlayServicesUtilLight.isGooglePlayServicesAvailable(Unknown Source:12)
        at com.google.android.gms.common.GoogleApiAvailabilityLight.isGooglePlayServicesAvailable(Unknown Source:5)
        at com.google.android.gms.common.GoogleApiAvailability.isGooglePlayServicesAvailable(com.google.android.gms:play-services-base@@17.1.0:96)
        at com.google.android.gms.common.GoogleApiAvailabilityLight.isGooglePlayServicesAvailable(Unknown Source:3)
        at com.google.android.gms.common.GoogleApiAvailability.isGooglePlayServicesAvailable(com.google.android.gms:play-services-base@@17.1.0:95)
        at com.baseflow.googleapiavailability.GoogleApiAvailabilityPlugin.onMethodCall(GoogleApiAvailabilityPlugin.java:105)
        at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:226)
        at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85)
        at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:631)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:336)
        at android.os.Looper.loop(Looper.java:174)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Reproduction steps

Run the plugin in a background service.

Configuration

Version: 2.0.3

Platform:

• 📱 iOS
• 🤖 Android

The implementation of the V2 embedding seems a little complicated.
The applicationContext should always be available to the GoogleApiAvailabilityPlugin class, and "activity" could be set depending on whether the activity has been connected or not.

The check

      if (context instanceof Activity) {
        Activity activity = (Activity) context;
        if (showDialog != null && showDialog) {
          googleApiAvailability.showErrorDialogFragment(activity, connectionResult, REQUEST_GOOGLE_PLAY_SERVICES);
        }
      }

could then be replaced by "if (activity != null)".

I use this library in common Dart code on two platforms and after upgrading to 5.0.0 in runtime there is an error

🚀 Feature Requests

Contextualize the feature

Describe the feature

Platforms affected (mark all that apply)

• [x ] 📱 iOS
• 🤖 Android

Please check the following before submitting a new issue.

• I have searched the existing issues.
• I have carefully read the documentation and verified I have added the required platform specific configuration.

Steps to reproduce

paste the code given below

Expected results

it checks for availability

Actual results

it fails with error

Code sample

if (Platform.isAndroid) {
      GooglePlayServicesAvailability availability =
          await GoogleApiAvailability.instance.checkGooglePlayServicesAvailability();
      log.d(availability.value);
    }

Screenshots or video

Screenshots or video demonstration

Version

5.0.0

Flutter Doctor output

[✓] Flutter (Channel stable, 3.19.6, on macOS 13.0.1 22A400 darwin-arm64, locale ru-RU)
    • Flutter version 3.19.6 on channel stable at /Users/svmolchan1/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (2 weeks ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/svmolchan1/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.88.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (3 available)
    • M2101K9AG (mobile) • cc706425 • android-arm64  • Android 13 (API 33)
    • macOS (desktop)    • macos    • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)       • chrome   • web-javascript • Google Chrome 120.0.6099.216

[✓] Network resources
    • All expected network resources are available.

• No issues found!

🐛 Bug Report

kotlin_version = '1.2.30'

Launching lib/main.dev.dart on ONEPLUS A6000 in debug mode...
Initializing gradle...
Resolving dependencies...
Gradle task 'assembleDevDebug'...
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/sandeeepcmsm/.pub-cache/hosted/pub.dartlang.org/flutter_webview_plugin-0.2.1+2/android/src/main/java/com/flutter_webview_plugin/WebviewManager.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/sandeeepcmsm/.pub-cache/hosted/pub.dartlang.org/flutter_webview_plugin-0.2.1+2/android/src/main/java/com/flutter_webview_plugin/WebviewManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
e: /Users/sandeeepcmsm/.pub-cache/hosted/pub.dartlang.org/google_api_availability-1.0.2/android/src/main/kotlin/com/baseflow/googleapiavailability/GoogleApiAvailabilityPlugin.kt: (29, 48): Type inference failed. Expected type mismatch: inferred type is Boolean? but Boolean was expected

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':google_api_availability:compileDebugKotlin'.

Compilation error. See log for more details

Reproduction steps

Configuration

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.9.7-pre.35, on Mac OS X 10.14 18A391, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
[✓] Android Studio (version 3.2)
[!] IntelliJ IDEA Community Edition (version 2018.1.5)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.27.2)
[✓] Connected device (2 available)

! Doctor found issues in 1 category.
Version: 1.x

Platform:

• 🤖 Android

🐛 Bug Report

I installed the package and imported it like this:

import 'package:google_api_availability/google_api_availability.dart';

Then in an async function I did this:

final availability = await GoogleApiAvailability.instance.checkGooglePlayServicesAvailability(true);

When I called function while running in an Android emulator I got this error:

ERROR:flutter[/lib/ui/ui_dart_state.cc]()(209)] Unhandled Exception: MissingPluginException(No implementation found for method checkPlayServicesAvailability on channel flutter.baseflow.com[/google_api_availability/methods]()

Expected behavior

I expected no error and an indication of whether the Google Play services are available.

Configuration

Version: 3.0.1

Platform:

• 📱 iOS
• 🤖 Android

🐛 Bug Report

This library still uses jCenter. jCenter doesn't get any updates anymore and should therefor be switched to mavenCentral.

See also https://developer.android.com/studio/build/jcenter-migration

Expected behavior

No dependencies on jCenter

Platform:

• 📱 iOS
• 🤖 Android