base / base-task Goto Github PK

• add deprecation notice to this package
• publish minor on npm
• rename to base-task
• publish base-task
• push to github and rename github repo

Base plugins which have app.use(tasks()) overwrite each other's tasks.

Suppose I am writing two base plugins, each of which export something like the following.

const tasks = require("base-task");
const pluginId = "my-id"; // generated
module.exports = function (app, ..._rest) {
    if (app.isRegistered(pluginId)) {
        return;
    }
    
    app.use(tasks());
    app.task("foo", function(done) {
        console.log("I am a task");
        done();
    });
}

If the first plugin defines task "foo", and the second "bar", then app will only have task "bar" because the tasks got reinitialized.

I can workaround this by using the following in place of app.use(tasks()).

    if (typeof app.task !== "function") {
        app.use(tasks());
    }

Should base-task use the isRegistered pattern, or is there a use case for reinitialization?