barbagroup / fmm_tutorial Goto Github PK

Most of the docstrings have their descriptions running on in a single line.
There should be newlines inserted so that they're readable.

In general, actually, max column width should be 79 characters in line with PEP8

and a copyright notice.

MIT License is good, and for a copyright notice, probably

Content under Creative Commons Attribution license CC-BY 4.0, code under MIT license (c) 2015 T. Wang, N. Clementi

Hi there,

I'm a PhD student in the group of Hans Fangohr, and I used this material to learn the concepts behind the Barnes-Hut method/FMM. I'd like to cite the repository in a paper that I'm writing - is there any chance the authors could put the repository onto Zenodo so I can cite the DOI?

Also wanted to say thanks; I found the material very instructive.

All the best,
Ryan

Hi there!

In 2022, there're some dependencies and commands are deprecated for Python 3.9 or later, here are some updates:

In treenode_helper.py you should change:
line 5: from numba import autjit -> from numba import jit
line 73 self.leaf = numpy.zeros(n_crit, dtype=numpy.int) -> self.leaf = numpy.zeros(n_crit, dtype=int)
line 75 self.child = numpy.zeros(8, dtype=numpy.int) -> self.child = numpy.zeros(8, dtype=int)
line 79 self.multipole = numpy.zeros(10, dtype=numpy.float) -> self.multipole = numpy.zeros(10, dtype=float)

In 04_tree_construction.ipyn you should change in class cell():
self.leaf = numpy.zeros(n_crit, dtype=numpy.int) -> self.leaf = numpy.zeros(n_crit, dtype=int)
self.child = numpy.zeros(8, dtype=numpy.int) -> self.child = numpy.zeros(8, dtype=int)
self.multipole = numpy.zeros(10, dtype=numpy.float) -> self.multipole = numpy.zeros(10, dtype=float)

In 06_treecode.ipynb you should change every clock() to time()

I hope it will be helpful for future readers

When I open the notebook with nbviewer in Chrome, some equations are truncated. For example, in lesson 2, the Taylor series expansion in 3D is:

In nbviewer, it becomes:

Half of the z-term of the first-order derivative is truncated.