baires / shouldideploy Goto Github PK

This is a more generic version of the previously addressed issue #594

The timezone should be used to lookup a calendar of public holidays in that region, and it should not recommend deploying on days before public holidays!

@baires Display a funny gifs/images below the reasons, to add more fun

To reproduce:

1. Go to https://shouldideploy.today/api?date=2023-03-31
2. Go to https://shouldideploy.today/api?date=2023-03-31T00:00:00.000Z

Expected Behavior
Has the same result for date=2023-03-31 or date=2023-03-31T00:00:00.000Z

Currently I would like to use the api but by choosing a specific day not necessarily today, it could be a date parameter where we enter a date in unix or iso string

The current method of infering the timezone (through moment) is not working for me :/ why don't we use the "new" Intl.DateTimeFormat().resolvedOptions().timeZone API to get the user time zone? this works fine for me, it has great compatibility, and if this isn't enough, we can always use moment as a fallback :D or vise versa, use this API as a fallback for moment.

Maybe you should check if is weekend before to check if is afternoon.

I see https://shouldideploy.today/api/slack?tz=UTC but how do I get this into slack as bot or something?

I saw some refactoring of CSS classes here on the latest commits, maybe one of them is the cause of this? Or it could also be a change on the Chrome engine.

I'm using:

Google Chrome
Version 90.0.4430.212 (Official Build) (x86_64)

Actually also happening on Safari

Safari
Version 14.0.2 (16610.3.7.1.9)

for some reasons the text overflows

adding hyphens: auto; on <h2 id="text"> seems to fix the problem

I can open a pr with the above solution or any other ideas?

Add new OC dynamically generated image @vercel/og

Hi!

Issue: the shrug reason (¯_(ツ)/¯) is not showing OK, i see it like **¯(ツ)/¯** instead of **¯_(ツ)/¯**

Posible solution: maybe you need to escape the backslash with another backslash in reasons.js file?

Platform: Chrome on Mac.

Thanks!

To reproduce:

1. Make a simple React app
2. Make a request to https://shouldideploy.today/api inside this app
3. You'll get this error:

Access to fetch at 'https://shouldideploy.today/api' from origin 'http://localhost:3002' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Expected Behavior
Allowing requests from all origins

I think is time to move this one to more modern stack. Nextjs seems a valid option

I noticed that deployments on Saturday and Sunday are allowed:

https://github.com/baires/shouldideploy/blob/master/app/constants.js#L11

I believe some additional messages are necessary for that, e.g.:
"Go home, you're drunk"
"How about Monday?"
"Beer?"

Its is time. It should be kinda simple

If you load it up on a Thursday evening, it'll still suggest you can wait until tomorrow even if "tomorrow" is Friday. I told my product director he can load shouldideploy.today to find out if we can deploy and he saw this on a Thursday evening: "YOU HAVE FULL DAY AHEAD OF YOU TOMORROW!" and now I'm screwed! This bug has now put Pornhub at risk for the weekend. If we accidentally break something that causes issues on Pornhub over the weekend, the stats show that the world will be at higher rate of crime and unwanted pregnancies. Please patch this ASAP. The human race and the yet-to-be-born will thank you.

Is it really safe to deploy during the weekends?

C'mon guys we need a special list of reasons for Xmas eve & new year

We are Sunday the website and the API says "True".

Usually it is not particularly good idea to deploy on normal deployment days: monday to thursday after 4pm.

reasons:
Call your wife?

https://shouldideploy.today/ is returning a 500. API still works, though

I think there could be some translations (or new texts) for other languages. It would be great to create some kind of i18n support

If I'm using the API, then I can change the date to see what the message is for different days. However, this doesn't work for the site: https://shouldideploy.today/api?date=2023-11-08 correctly tells me I can deploy, but https://shouldideploy.today/?date=2023-11-08 still tells me not to deploy because of Christmas