b-tsao / bored-games Goto Github PK

This will be a major change. It will include refactoring all code as well as basically reviewing the full current code.

BGIOClient should have a toolbar that allows players to interact with the framework (like restarting the game for host, returning to lobby, etc) (To be designed)

Ideally, I would like some hover effect and one-click to discard, but then we would have to change how to select kongs and claims.

Add player information for each user. This includes:

• Profile picture
• Name
• Points

Dependent on #17.

When server has logic to detect claim options, we can implement one-click actions on the UI for the following:

• During claim stage, show actions if discarded tile is claimable. Possible actions are chow, pong, kong, and win.
• During discard stage, show kong and win action when possible.

With this, we don't need to select specify tiles anymore and instead present possible combinations.

Similar to VSCode extensions (.vsix) I would like games to be able to package itself (with its own package.json and dependencies) and have the framework install the games.

This should include being able to put games into 'maintenance' or 'live' mode from the server side.

Chow has regressed due to TypeScript conversion

The line below doesn't work as expected because of unclear type addition and comparison.

Server will parse the hand along with the last discarded tile to retrieve possible combinations.
EDIT: Upon design thinking, it makes more sense for client to process the hand during claim phase for available players.
Reason: The server would have to process for 3 players, in addition to the processing for all on-going games, it just makes sense for individual clients to process their own hand and find available combinations, sending the index of the tiles in the player's hand for which they want to combo it with the discard (basically what the server expects the client to pass in currently, but manually).

Security wise, there should be no issue as the server knows what are in the players hand and the client sends the index of the tile position within the player's hand.

If no combinations are available, player will have an auto-skip passed in from the client once the timer is up (Issue #16)

If possible combinations are available, they should be categorized and presented to the player to pick one of the combinations or skip.

Due to limitations of boardgame.io, server sided timers currently are not possible. The server will continue to expect actions per stage while the client will handle any automated actions like auto-skipping a tile. Exact timer should be configurable.

If a claim was successful, the draw animation shows for the last card even though no new tile was drawn.

Currently, only buttons are using Material-UI. Need refactor the rest of the UI to use Material-UI.

https://material-ui.com/

See how/if it can be used to replace webpack/babel

command: node -r esm

We can add fun interactions in the game for players waiting on other players, like throwing eggs or tomatoes at other players. (Especially the one taking too long)

Pong, kong, chow tiles are put in the revealed hand array, but on win the rest of the remaining hand are also mixed into the revealed hand array. This messes with knowing if there were any pong, kong, or chow during the gameplay though.

Players are ordered in the following positions:

The top player's current hand layout is:

Exposed Hand
--------------------
Concealed Hand

This layout needs to be changed to:

Concealed Hand
--------------------
Exposed Hand

the framework should handle if the game's UI crashes (ends in exception).
Instead of the white screen of death, the game should catch the exception, record it, and return the player to the lobby.

Automatically draw tiles for players.

Cases:

• During player's draw phase, automatically draw from the beginning.
• Player draws a flower, automatically draw from the end.
• Player claims or declares a kong, automatically draw from the end.

A chatroom will be added as a layer over games

Mahjong starts with the east player rolling the dice. If the player rolling the dice wins, they keep the dice. If they lose, the dice moves counter clockwise to the next player. Once the dice makes a full round (back to the east), that's one game session.

• Dealer (starting East seat, always same person) - use icon
• Current dice holder (rotates) - use icon
• Prevalent Wind - use Mahjong unicode
• Number of tiles left
• Number of dead tiles(?)

On the server side, concealed kongs from other players are currently structured below.

  "players": {
    "0": {
      "hand": 8,
      "concealed": [
        "kong",
        "kong"
      ],

We should include the length of the kong to avoid using a magic number on the client.

After fixing the above, the client needs to update OpponentHand to consume the new format.