Code Monkey home page Code Monkey logo

terraform-azurerm-avm-res-operationalinsights-workspace's People

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

terraform-azurerm-avm-res-operationalinsights-workspace's Issues

Output naming and values are incorrect

The output values do not reflect the names. For example both "id" and "workspace_id" have the same value (which returns all the attributes). Currently to get the value for the workspace id I have to use "module.module_name.id.id". I would suggest just one output like:

output "workspace" {
  description = "The log analytics workspace attributes."
  value       = azurerm_log_analytics_workspace.this
}

This would mean that using the output elsewhere I would be writing module.module_name.workspace.id which would be better more accurate naming and look nicer.

[AVM Module Issue]:

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.1.3

(Optional) Correlation Id

No response

Description

The output "workspace_id" returns the entire workspace resource, not the ID.

Current code is:

output "workspace_id" {
  description = "The Resource ID of the Log Analytics Workspace."
  value       = azurerm_log_analytics_workspace.this
}

Suggest to replace with:

output "workspace_id" {
  description = "The Resource ID of the Log Analytics Workspace."
  value       = azurerm_log_analytics_workspace.this.id
}

[AVM Module Issue]: Workspace Outputs Overwritten . Returning Object instead of Properties

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Module specific issue

  • I confirm that this issue is about this AVM module and not about the resource itself, or how to use Terraform.

Issue Type?

Bug

(Optional) Module Version

0.1.3

(Optional) Correlation Id

No response

Description

The commit from a week ago 19543b3 has the right references, but the Chore branch: #18 brought over the object references vs the ones that were in the output correction branch.

I think I'm following the git flow of commits that this looks like an error pre generation of 0.1.3. If I'm mistaken, my apologies.

Expectations post fix is workspace_id reference the id and no longer the workspace object.

Action required: migrate or opt-out of migration to GitHub inside Microsoft

Migrate non-Open Source or non-External Collaboration repositories to GitHub inside Microsoft

In order to protect and secure Microsoft, private or internal repositories in GitHub for Open Source which are not related to open source projects or require collaboration with 3rd parties (customer, partners, etc.) must be migrated to GitHub inside Microsoft a.k.a GitHub Enterprise Cloud with Enterprise Managed User (GHEC EMU).

Action

✍️ Please RSVP to opt-in or opt-out of the migration to GitHub inside Microsoft.

❗Only users with admin permission in the repository are allowed to respond. Failure to provide a response will result to your repository getting automatically archived.🔒

Instructions

Reply with a comment on this issue containing one of the following optin or optout command options below.

✅ Opt-in to migrate

@gimsvc optin --date <target_migration_date in mm-dd-yyyy format>

Example: @gimsvc optin --date 03-15-2023

OR

❌ Opt-out of migration

@gimsvc optout --reason <staging|collaboration|delete|other>

Example: @gimsvc optout --reason staging

Options:

  • staging : This repository will ship as Open Source or go public
  • collaboration : Used for external or 3rd party collaboration with customers, partners, suppliers, etc.
  • delete : This repository will be deleted because it is no longer needed.
  • other : Other reasons not specified

Need more help? 🖐️

AVM-Review

Dear module owner,

As per the agreed module ownership requirements & responsibilities at the time of assignment, the AVM Team is opening this issue to request you to kindly review your module against the below AVM specs and confirm that they are met by the module. We appreciate if you don't close this issue till the review is complete. This review is required as a pre-req to be able to eventually publish the module as v1. AVM team would be happy to assist with the review and any questions that you might have around this.

Requested action is to complete below tasks and update the status column in the table below.

Tasks

# Spec Status [Y/N/NA] Comments
1 ID: SFR1 - Category: Composition - Preview Services
2 ID: SFR2 - Category: Composition - WAF Aligned
3 ID: SFR3 - Category: Telemetry - Deployment/Usage Telemetry
4 ID: SFR4 - Category: Telemetry - Telemetry Enablement Flexibility
5 ID: SFR5 - Category: Composition - Availability Zones
6 ID: SFR6 - Category: Composition - Data Redundancy
7 ID: SNFR25 - Category: Composition - Resource Naming
8 ID: SNFR1 - Category: Testing - Prescribed Tests
9 ID: SNFR2 - Category: Testing - E2E Testing
10 ID: SNFR3 - Category: Testing - AVM Compliance Tests
11 ID: SNFR4 - Category: Testing - Unit Tests
12 ID: SNFR5 - Category: Testing - Upgrade Tests
13 ID: SNFR6 - Category: Testing - Static Analysis/Linting Tests
14 ID: SNFR7 - Category: Testing - Idempotency Tests
15 ID: SNFR24 - Category: Testing - Testing Child, Extension & Interface Resources
16 ID: SNFR8 - Category: Contribution/Support - Module Owner(s) GitHub
17 ID: SNFR20 - Category: Contribution/Support - GitHub Teams Only
18 ID: SNFR9 - Category: Contribution/Support - AVM & PG Teams GitHub Repo Permissions
19 ID: SNFR10 - Category: Contribution/Support - MIT Licensing
20 ID: SNFR11 - Category: Contribution/Support - Issues Response Times
21 ID: SNFR12 - Category: Contribution/Support - Versions Supported
22 ID: SNFR23 - Category: Contribution/Support - GitHub Repo Labels
23 ID: SNFR14 - Category: Inputs - Data Types
24 ID: SNFR22 - Category: Inputs - Parameters/Variables for Resource IDs
25 ID: SNFR15 - Category: Documentation - Automatic Documentation Generation
26 ID: SNFR16 - Category: Documentation - Examples/E2E
27 ID: SNFR17 - Category: Release - Semantic Versioning
28 ID: SNFR18 - Category: Release - Breaking Changes
29 ID: SNFR19 - Category: Publishing - Registries Targeted
30 ID: SNFR21 - Category: Publishing - Cross Language Collaboration
31 ID: RMFR1 - Category: Composition - Single Resource Only
32 ID: RMFR2 - Category: Composition - No Resource Wrapper Modules
33 ID: RMFR3 - Category: Composition - Resource Groups
34 ID: RMFR4 - Category: Composition - AVM Consistent Feature & Extension Resources Value Add
35 ID: RMFR5 - Category: Composition - AVM Consistent Feature & Extension Resources Value Add Interfaces/Schemas
36 ID: RMFR8 - Category: Composition - Dependency on child and other resources
37 ID: RMFR6 - Category: Inputs - Parameter/Variable Naming
38 ID: RMFR7 - Category: Outputs - Minimum Required Outputs
39 ID: RMNFR1 - Category: Naming - Module Naming
40 ID: RMNFR2 - Category: Inputs - Parameter/Variable Naming
41 ID: RMNFR3 - Category: Composition - RP Collaboration
42 ID: PMFR1 - Category: Composition - Resource Group Creation
43 ID: PMNFR1 - Category: Naming - Module Naming
44 ID: PMNFR2 - Category: Composition - Use Resource Modules to Build a Pattern Module
45 ID: PMNFR3 - Category: Composition - Use other Pattern Modules to Build a Pattern Module
46 ID: PMNFR4 - Category: Hygiene - Missing Resource Module(s)
47 ID: PMNFR5 - Category: Inputs - Parameter/Variable Naming
48 ID: TFFR1 - Category: Composition - Cross-Referencing Modules
49 ID: TFFR2 - Category: Outputs - Additional Terraform Outputs
50 ID: TFNFR1 - Category: Documentation - Descriptions
51 ID: TFNFR2 - Category: Documentation - Module Documentation Generation
52 ID: TFNFR3 - Category: Contribution/Support - GitHub Repo Branch Protection
53 ID: TFNFR4 - Category: Composition - Code Styling - lower snake_casing
54 ID: TFNFR5 - Category: Testing - Test Tooling
55 ID: TFNFR6 - Category: Code Style - The Order of resource and data in the Same File
56 ID: TFNFR7 - Category: Code Style - The Use of count and for_each
57 ID: TFNFR8 - Category: Code Style - Orders Within resource and data Blocks
58 ID: TFNFR9 - Category: Code Style - Order within a module block
59 ID: TFNFR10 - Category: Code Style - Values in ignore_changes passed to provider, depends_on, lifecycle blocks are not allowed to use double quotations
60 ID: TFNFR11 - Category: Code Style - null comparison as creation toogle
61 ID: TFNFR12 - Category: Code Style - Optional nested object argument should use dynamic
62 ID: TFNFR13 - Category: Code Style - Use coalesce or try when setting default values for nullable expressions
63 ID: TFFR14 - Category: Inputs - No enabled or module_depends_on variable
64 ID: TFNFR15 - Category: Code Style - Order to define variable
65 ID: TFNFR16 - Category: Code Style - Name of a variable MUST follow rules
66 ID: TFNFR17 - Category: Code Style - Every variable MUST come with a description
67 ID: TFNFR18 - Category: Code Style - Every variable MUST have an appropriate type
68 ID: TFNFR19 - Category: Code Style - variable containing confidential data should be declared as sensitive = true
69 ID: TFNFR20 - Category: Code Style - Declare nullable = false when it’s possible
70 ID: TFNFR21 - Category: Code Style - MUST NOT declare nullable = true
71 ID: TFNFR22 - Category: Code Style - MUST NOT declare sensitive = false
72 ID: TFNFR23 - Category: Code Style - variable with sensitive = true MUST NOT have default value unless the default value represents turning off a feature, like default = null or default = []
73 ID: TFNFR24 - Category: Code Style - Deal with deprecated variable
74 ID: TFNFR25 - Category: Code Style - All verified modules MUST have terraform.tf file and required_version MUST be set
75 ID: TFNFR26 - Category: Code Style - Providers MUST be declared in the required_providers block in terraform.tf and MUST have a constraint on minimum and maximum major version
76 ID: TFNFR27 - Category: Code Style - Declaration of a provider in the module
77 ID: TFNFR28 - Category: Code Style - output MUST be arranged alphabetically
78 ID: TFNFR29 - Category: Code Style - output contains confidential data should declare sensitive = true
79 ID: TFNFR30 - Category: Code Style - Dealing with Deprecated outputs
80 ID: TFNFR31 - Category: Code Style - locals.tf MUST contain only locals blocks
81 ID: TFNFR32 - Category: Code Style - local should be arranged alphabetically
82 ID: TFNFR33 - Category: Code Style - local should use types as precise as possible
83 ID: TFNFR34 - Category: Code Style - Feature toggle MUST be used to ensure forward compatibility of versions and avoid unexpected changes caused by upgrades
84 ID: TFNFR35 - Category: Code Style - Changes that might be breaking change MUST be reviewed with caution
85 ID: TFNFR36 - Category: Code Style - Example code MUST set prevent_deletion_if_contains_resources to false in provider block
86 ID: TFNFR37 - Category: Code Style - Module owner MAY use tools like newres

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.