Code Monkey home page Code Monkey logo

Comments (12)

kanika1894 avatar kanika1894 commented on July 4, 2024 1

If I am not wrong, #43 this solves the issue, right?

from aci-deploy.

daliborsavanovic avatar daliborsavanovic commented on July 4, 2024 1

A year later this is still not fixed(released)?

from aci-deploy.

chelnak avatar chelnak commented on July 4, 2024 1

Sure, will do. I put it here because I felt like it was a bit of a regression from the fix.

from aci-deploy.

jakep36 avatar jakep36 commented on July 4, 2024

I'm having this issue as well.

from aci-deploy.

jakep36 avatar jakep36 commented on July 4, 2024

I think this will always throw an error if ipAddress != 'Public'

aci-deploy/src/taskparameters.ts

Line 71 in 5eddcda

if(ipAddress != "Public" && "Private") {

I think something like if(!(ipAddress == "Public" || ipAddress == "Private")) would work. I'm not exactly sure how to contribute here. This seems to be the same pattern for the other params that have either options like @crbaker mentioned above.

When I try to use my fork as the action I got a Failed to fetch Azure access token error.

from aci-deploy.

kf6kjg avatar kf6kjg commented on July 4, 2024

Underlying bug also causes #17.

Looks like whomever wrote the initial code thought that a != b && c evaluated like ![b, c].includes(a) instead of as it really does (a != b) && (true)...

from aci-deploy.

github-actions avatar github-actions commented on July 4, 2024

This issue is marked need-to-triage for generating issues report.

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 4, 2024

@daliborsavanovic @crbaker @jakep36
This has been fixed in the patch version. We'll soon update the major version as well.
Can you please verify if using [email protected] solves the issue and works well?

from aci-deploy.

daliborsavanovic avatar daliborsavanovic commented on July 4, 2024

Hi @kanika1894,

Haven't tried new version, but I can see a flaw there also, you're missing network profile parameter..
I have fixed my own (forked) version of this and continued..

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 4, 2024

Hey @daliborsavanovic , can you please more context around the network profile parameter?
The intention behind having v1.1.1 was to fix #17 and #3.
But as per my understanding, there is something else that needs to be included?
Thank you for your inputs :)

from aci-deploy.

chelnak avatar chelnak commented on July 4, 2024

Looks like this is still broken because there is a dependency on dns-name-label that can't be met if you want private ip.

aci-deploy/src/taskparameters.ts

Line 48 in abb2c5f

this._dnsNameLabel = core.getInput('dns-name-label', { required: true });

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 4, 2024

@chelnak can you please create a separate issue for this?
This seems like making a parameter optional based on a condition, which we can handle separately.
The fix for the conditions is rolled out using #43

from aci-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.