Code Monkey home page Code Monkey logo

Comments (11)

kanika1894 avatar kanika1894 commented on July 23, 2024 1

Hey @cilerler,
Thanks for pointing this out. As of now, this action only supports Public IP scenario. Updated : https://github.com/Azure/aci-deploy/blob/master/action.yml#L69
Supporting Private IP will be taken up as an enhancement.

from aci-deploy.

cilerler avatar cilerler commented on July 23, 2024

Are you sure that you don't want to mark it as "Bug" since it allows you to set a value, but then it throws an error?
I mean, it literally throws an error if you set Private; to me, it means a bug and not an enhancement.

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 23, 2024

Since we are calling out explicitly in the action ReadMe as well as action.yml that Private IP scenario is not supported, we'll be taking this as an enhancement.

from aci-deploy.

github-actions avatar github-actions commented on July 23, 2024

This issue is idle because it has been open for 14 days with no activity.

from aci-deploy.

zmckinnon avatar zmckinnon commented on July 23, 2024

I am also having this issue. Is there some reason why Private IP addresses is not supported? Any idea on the timeline on this? Are y'all accepting PRs?

from aci-deploy.

github-actions avatar github-actions commented on July 23, 2024

This issue is idle because it has been open for 14 days with no activity.

from aci-deploy.

BALAGA-GAYATRI avatar BALAGA-GAYATRI commented on July 23, 2024

@zmckinnon We are accepting PRs. We will be glad to accept contributions.

from aci-deploy.

github-actions avatar github-actions commented on July 23, 2024

This issue is idle because it has been open for 14 days with no activity.

from aci-deploy.

davemaul avatar davemaul commented on July 23, 2024

Is there a reason for this restriction? In Azure Portal it's absolutely possible to create a container instance without a dns label name and a private IP address. I'm curious. :)

from aci-deploy.

davemaul avatar davemaul commented on July 23, 2024

Tested it. There's no reason. Sent a PR. :)

from aci-deploy.

github-actions avatar github-actions commented on July 23, 2024

This issue is idle because it has been open for 14 days with no activity.

from aci-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.