Code Monkey home page Code Monkey logo

Comments (12)

alexlydiate avatar alexlydiate commented on July 23, 2024 2

@iluxa86 certainly pointed in the right direct - pull request #38 fixes this, which on our fork is working fine.

from aci-deploy.

iluxa86 avatar iluxa86 commented on July 23, 2024

this line should be changed to
if(restartPolicy not in ("Always", "OnFailure", "Never")) {

But I do not have permissions to submit PR

from aci-deploy.

iluxa86 avatar iluxa86 commented on July 23, 2024

I did not realize it is TS code.
The code should be:
if(!["Always", "OnFailure", "Never"].includes(restartPolicy)) {

from aci-deploy.

anraghun avatar anraghun commented on July 23, 2024

@narula0781

from aci-deploy.

alexlydiate avatar alexlydiate commented on July 23, 2024

We've also met this - a real pain. Seems @iluxa86 has given the fix three months ago...

from aci-deploy.

huinalam avatar huinalam commented on July 23, 2024

when is it resolved?
restart policy bug is still alive.

from aci-deploy.

alexlydiate avatar alexlydiate commented on July 23, 2024

@huinalam I've given up on this. I met another, similar bug, and concluded there must be a better way. And there is - just use https://github.com/azure/cli directly, and then you can do whatever the CLI allows you too, and you end up with a better understanding of what's going on, much more power over it - and, it works.

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 23, 2024

If I am not wrong, #43 this solves the issue, right?
@iluxa86 @alexlydiate

from aci-deploy.

jseadragon avatar jseadragon commented on July 23, 2024

It appears this has been fixed in master, but we do not have a new release cut. What's the ETA on getting a new tag with this change?

from aci-deploy.

github-actions avatar github-actions commented on July 23, 2024

This issue is marked need-to-triage for generating issues report.

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 23, 2024

@jseadragon @iluxa86 @alexlydiate
This has been fixed in the patch version. We'll soon update the major version as well.
Can you please verify if using [email protected] solves the issue and works well?

from aci-deploy.

kanika1894 avatar kanika1894 commented on July 23, 2024

Fixed in v1 as well.

from aci-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.