Code Monkey home page Code Monkey logo

pallypower's People

Contributors

aznamirwow avatar esreverwow avatar himea-saito avatar saschajankowiak avatar treeston avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

pallypower's Issues

PP clearing settings in WOTLK CLassic

As of WOTLK Classic, I've been observing that settings have been getting cleared.

  • Sometimes this is swapping from say a bank alt to a main toon.
  • Sometimes this happens when zoning into dungeons.

Remove paladin that left the party/raid from pallypower

Hi!

A the moment, when a paladin leave the group, PallyPower doesn't removes it from the UI, event with the "update" button (not sure about the name in english) and one needs to /reload to actually cleanup the pal list.

Would be great if pallypower could automatically remove them when they leave, or at least update the list when using the update button from the blessing assignment window

PP does not recognize timer for ZG 5-piece timer

The Freethinker's 5 piece gives 10% to buff duration, making greater blessings 17 minutes, but the PP frames do not recognize the buff. I don't know if the spell ID is different - maybe a check for gear slots when the blessing is cast?

TY
image

Ability to save smaller assignments?

Hey,

I've been having the issue that whenever I relog or get into the raid, we need to setup PP totally from scratch again.
Every raid we assign the buffs for us, which is quite cumbersome.

I know there is a weakaura that allows to others to control their single buffs. However I wasn't really able to understand how it is doing it.

Ideally I'd simply be able to save a setup once I'm happy with it and then use it as a template when the next raid starts. That would include the buffs for each class per paladin, as well as the auras and single buff assignments.

Do you think something like this can be done?

Cheers
-Martin

Errors when opening buff assignments

When opening buff assignments on v1.4.4-classic on TBCC client I get the following error:

76x PallyPower\PallyPower-v1.4.4-classic.lua:641: attempt to perform arithmetic on field 'start' (a nil value)
[string "@PallyPower\PallyPower-v1.4.4-classic.lua"]:641: in function 'PallyPowerBlessingsGrid_Update'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>`

Locals:
self = PallyPowerBlessingsFrameTitle {
 0 = <userdata>
}`
elapsed = 0.007000
numPallys = 0
numMaxClass = 1
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 1 = "Zaresh"
}
(for control) = 1
i = 1
name = "Zaresh"
fname = "PallyPowerBlessingsFramePlayer1"
SkillInfo = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 4 = <table> {
 }
 6 = <table> {
 }
 AuraInfo = <table> {
 }
 subgroup = 1
 symbols = 0
 CooldownInfo = <table> {
 }
}
BuffInfo = <table> {
 1 = 4
 2 = 4
 3 = 1
 4 = 1
 5 = 1
 6 = 4
 7 = 4
 8 = 4
 9 = 1
 10 = 2
}
NormalBuffInfo = nil
AuraInfo = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 6 = <table> {
 }
}
aura = 1
CooldownInfo = <table> {
 2 = <table> {
 }
}
(for index) = 2
(for limit) = 2
(for step) = 1
id = 2
(*temporary) = <table> {
}
(*temporary) = <function> defined @PallyPower\PallyPower.lua:1947
(*temporary) = <table> {
 CanControl = <function> defined @PallyPower\PallyPower.lua:1872
 NormalBuffs = <table> {
 }
 modules = <table> {
 }
 CancelTimer = <function> defined @ElvUI\Libraries\Core\Ace\AceTimer-3.0\AceTimer-3.0.lua:147
 AddRealmName = <function> defined @PallyPower\PallyPower.lua:1956
 Skins = <table> {
 }
 ParseMessage = <function> defined @PallyPower\PallyPower.lua:1660
 GetSpellID = <function> defined @PallyPower\PallyPower.lua:2964
 SetDefaultModulePrototype = <function> defined @ElvUI\Libraries\Core\Ace\AceAddon-3.0\AceAddon-3.0.lua:409
 AutoAssignAuras = <function> defined @PallyPower\PallyPower.lua:4161
 player = "Zaresh"
 BattleGroundTemplates = <table> {
 }
 IsEnabled = <function> defined @ElvUI\Libraries\Core\Ace\AceAddon-3.0\AceAddon-3.0.lua:451
 IsAuraActive = <function> defined @PallyPower\PallyPower.lua:4091
 ScheduleTimer = <function> defined @ElvUI\Libraries\Core\Ace\AceTimer-3.0\AceTimer-3.0.lua:94
 AssignPlayerAsClass = <function> defined @PallyPower\PallyPower.lua:1044
 GetClassID = <function> defined @PallyPower\PallyPower.lua:1972
 AutoBuffedList = <table> {
 }
 RegisterMessage = <function> defined @ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
 UnregisterMessage = <function> defined @ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
 PerformAuraCycleBackwards = <function> defined @PallyPower\PallyPower.lua:4063
 PerformCycleBackwards = <function> defined @PallyPower\PallyPower.lua:945
 UpdateRoster = <function> defined @PallyPower\PallyPower.lua:1981
 GetBuffExpiration = <function> defined @PallyPower\PallyPower.lua:2603
 SetEnabledState = <function> defined @ElvUI\Libraries\Core\Ace\AceAddon-3.0\AceAddon-3.0.lua:424
 ZONE_CHANGED_NEW_AREA = <function> defined @PallyPower\PallyPower.lua:1520
 ScanCooldowns = <function> defined @PallyPower\PallyPower.lua:1296
 GROUP_JOINED = <function> defined @PallyPower\PallyPower.lua:1538
 ReportChannels = <function> defined @PallyPower\PallyPower.lua:759
 OnEnable = <function> defined @PallyPower\PallyPower.lua:171
 GROUP_LEFT = <function> defined @PallyPower\PallyPower.lua:1558
 GetRFExpiration = <function> defined @PallyPower\PallyPower.lua:2659
 OnInitialize = <function> defined @PallyPower\PallyPower.lua:84
 UnregisterAllEvents = <function> defined @ElvUI\Libraries\Core\Ace\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
 isBCC = true
 Templates = <table> {
 }
 PerformAuraCycle = <function> defined @PallyPower\PallyPower.lua:4030
 optionsFrame = <unnamed> {
 }
 GetUnitAndSpellSmart = <function> defined @PallyPower\PallyPower.lua:2991
 OnProfileChanged = <function> defined @PallyPower\PallyPower.lua:211
 GetName = <function> defined @

PallyPower Error

This issue persists after uninstalling all addons, clearing Interface and WTF folders then installing and using PallyPower in isolation. It also still persists after uninstalling the game client and being the only addon installed on a fresh client

Comparing the error with the code it seems to be that the CooldownInfo is not populated on line 635 before it is accessed on 641 - I could be wrong though as I'm not familiar with lua or this codebase, I'm just trying to give as much info as I can to make investigation easier.

Random lua error upon pressing release spirit in an instance environment (5 man dungeon)

8x PallyPower/PallyPower.lua:1518: Usage: ChatThrottleLib:SendAddonMessage("{BULK|
ORMAL||ALERT}", "prefix", "text", "chattype"[, "target"])
[string "=[C]"]: in function error' [string "@AtlasLootClassic/Libs/AceComm-3.0-12/ChatThrottleLib.lua"]:462: in function SendAddonMessage'
[string "@PallyPower/PallyPower.lua"]:1518: in function SendMessage' [string "@PallyPower/PallyPower.lua"]:1411: in function SendSelf'
[string "@PallyPower/PallyPower.lua"]:1533: in function <PallyPower/PallyPower.lua:1525>
[string "=[C]"]: ?
[string "@PallyPower/Libs/AceBucket-3.0-4/AceBucket-3.0.lua"]:69: in function <...dOns/PallyPower/Libs/AceBucket-3.0/AceBucket-3.0.lua:67>
[string "@PallyPower/Libs/AceBucket-3.0-4/AceBucket-3.0.lua"]:83: in function `func'
[string "@Details/Libs/AceTimer-3.0-17/AceTimer-3.0.lua"]:57: in function <...ceDetails/Libs/AceTimer-3.0/AceTimer-3.0.lua:50>

Locals:
(*temporary) = "Usage: ChatThrottleLib:SendAddonMessage("{BULK|
ORMAL||ALERT}", "prefix", "text", "chattype"[, "target"])"

incorrect version in classic TOC file

hiya, the latest update for the addon still has 11401 in the toc file for vanilla
since the reason for the bump appears to be a toc bump for tbc one would hope that they would bump the version in vanilla as well...

Pets randomly assigned to different classes

Sometimes pets are assigned to a class, and the icons for that class shows blue/yellow as if buffs are missing, even though buffs are not missing on any player character. "show pets" is checked, Version 1.44
Opening buff assignments then shows the pets under that class as if they were a player

also warlock pets are shown, even though you can't buff them

Single Target Buff Assignment not working

This ist the error i get when trying to assign buffs for individual ppl.

Message: ..\AddOns\PallyPower\PallyPower.lua line 424:
   attempt to concatenate local 'tname' (a nil value)
Debug:
   [string "=[C]"]: ?
   [string "@PallyPower\PallyPower.lua"]:424: SendNormalBlessings()
   [string "@PallyPower\PallyPower.lua"]:495: PallyPowerGrid_NormalBlessingMenu()
   [string "@PallyPower\PallyPower.lua"]:509: PallyPowerPlayerButton_OnClick()
   [string "*:OnClick"]:1:
      [string "*:OnClick"]:1

Seal of Vengeance

Hello

the Seal of Vengeance, dont show up in Pallypower. I use German Client.
Bild_2022-09-01_151948848
Bild_2022-09-01_152013216
When i use Light it works.
image

High cpu usage

I am using PP on wotlk classic and the cpu usage (not memory) of pallypower apears to be way higher than of all my other add ons.
in a 40 man raid it is using 33+ ms / s

Settings reverted

I am on Classic Era and have seen settings being reverted a short while after setting them. This only seem to happen for characters on another realm, i.e they have a realm suffix on their name.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.