Code Monkey home page Code Monkey logo

Comments (14)

Engineerator avatar Engineerator commented on May 26, 2024 2

This might be a minor cosmetic issue, but I think that we should change the default side text to "Text" because it doesn't sound right to say that a card has two front sides.

from flashcard-maker-android.

greyboxgt avatar greyboxgt commented on May 26, 2024 1

Let me explain why this could be very useful. There are situations where cards "back" and "front" sides are supposed to be mixed within one set. Especially if you are learning, you may want to have mixed backs and fronts in one set to train your brain better. For example, not just english, english, english, english, english words for the front side, but, rather english, russian, russian, english, english. This way your brain should works harder to expect to translate in both "directions" which is very good for learning. To achieve that I have to edit front and back sides manually which is much more time consuming than just flipping the card. I am sure that would be a very nice feature that will help learning. And you can always flip the card again in a simple click if you are "just visiting".

from flashcard-maker-android.

Engineerator avatar Engineerator commented on May 26, 2024 1

Thank you for adding this great feature!

However, I have discovered a serious issue that impacts the usability of the program. When I go to edit the back of a card, the text field that appears, shows the text on the front side of the card instead of the back side. I noticed that just before entering the text editing menu, the card flips back to the front which might be causing this issue.

from flashcard-maker-android.

greyboxgt avatar greyboxgt commented on May 26, 2024 1

It is very nice that we have the "Shuffle cards" feature. I think it would also be useful to introduce the "Shuffle card sides" feature when the card number in the set does not change, but only the sides of the cards in the set are randomly changed. The result will be similar to #25 (comment), but automatic instead of manual. And we can always use the "Shuffle Cards" command separately in addition to the "Shuffle card sides" if we want.

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

I think flipping a card in editing module should not save the card side state since you are just visiting the card to make sure it has proper contents on its sides.
Wouldn't it be better to have special indicators to say "you're editing the back side" or "you're editing the front"?

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

Feel free to reopen the issue if something comes up

from flashcard-maker-android.

greyboxgt avatar greyboxgt commented on May 26, 2024

Works well for me!

Thank you @AbduazizKayumov for the update and thank you @Engineerator for making the .apk for me!

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

Thank you for the bug report. Yes, it is a serious issue, I'll try to fix as soon as possible

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

The original fix involved flipping sides of a card model object when user flips the card view, this commit removes "isEditingBack" boolean from the card model class. "isEditingBack" is unnecessary from now on as the editor always edits the front side.
Feel free to reopen it if something comes up.

from flashcard-maker-android.

Engineerator avatar Engineerator commented on May 26, 2024

This commit seemed to have fixed this issue!

I have discovered another issue that is related to this issue. When flipping to the back side of an empty card, just before pressing on it to edit the text, the default string "Back side" changes to "Front side". Without changing anything and returning back to the card, the back side of the card shows the "Front side" string.

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

Yes, it is an expected behavior, the visible side is always "front" since we're saving the card state on each flip. Let's remove the words, "front" and "back", and use "Front side" as a default side text.

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

Let me know if there is any other word that we can use for default text on card sides.

from flashcard-maker-android.

azizkayumov avatar azizkayumov commented on May 26, 2024

Published a new release on Google Play, let me know if something comes up

from flashcard-maker-android.

greyboxgt avatar greyboxgt commented on May 26, 2024

Thank you, thank you, thank you for adding this new feature!!! It works very well and the new icon looks very nice!

from flashcard-maker-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.