Code Monkey home page Code Monkey logo

Comments (11)

Azgaar avatar Azgaar commented on May 20, 2024 1

Hi Volumunox,

Thanks for reporting! Not sure what is the root cause here. Will take a look

from fantasy-map-generator.

MortenHolmRep avatar MortenHolmRep commented on May 20, 2024 1

Sure can. This is freshly generated. As you can see from the first image, I highlighted the duplication.
In the second image i seperated the paths to see it visually.

1a
1b

from fantasy-map-generator.

MortenHolmRep avatar MortenHolmRep commented on May 20, 2024 1

This seemed like a better look, so uploading this as well :)

1c

from fantasy-map-generator.

MortenHolmRep avatar MortenHolmRep commented on May 20, 2024

I suspect the disjointed path is due to the rivers narrowing, so each step increment in the river uses a new segment. I'm still a novice in regards to coding and don't know your code too well, but if the segment requires the previous line to make the new one, maybe a duplication error or mishap occurs when it tries to add the new line resulting in a double path.

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

Yes, to make a narrowing line I split it into a small segments. The more correct variant is too draw a narrowed polygon, not a line, but I have to change a code a lot to implement it. And there is background shade element.

I don't have Illustrator and usually use Inkscape. In Inkscape it looks like supposed. Could you share a screenshot of its actual Illustrator look?

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

Thanks! It could be a element, that should not be displayed at all. And as I see background shadow is displayed as a simple line. I'm going to change the narrowed line to a polygon one day. And I will try to install Illustrator to check the svg correctness.

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

Tried Illustrator, got the triplication of the river element. Not sure what is wrong, but definitely need to re-build river generation.

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

Not sure I can fix it soon. Closing for a while

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

I'd reworked river generation algorithm and planning to deploy it next week. This should fix the issue.

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

The issue is fixed, pending deployment (need to fix some non-related issues)

from fantasy-map-generator.

Azgaar avatar Azgaar commented on May 20, 2024

The river rendering code is re-worked and the issue is not actual anymore. Please remove the old site from browser cache and check the new version

from fantasy-map-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.