Code Monkey home page Code Monkey logo

Comments (4)

buttonpushertv avatar buttonpushertv commented on June 11, 2024 1

Having duplicates is not any sort of show stopping issue. Creating notes in Obsidian with the index as part of the name or using a tool that is now part of the JSON import plugin (processing of pseudo helpers on the import stage of filenaming) seems like good approaches to work within the existing system of having a map that may have duplicates.

Thanks for your thoughts. I think I'll close this issue and make use of the options I do have on the import side. No need to make any plans on FMG's end for now.

from fantasy-map-generator.

DeuzeksMcKinna avatar DeuzeksMcKinna commented on June 11, 2024

Since the name generation is procedural, there's the risk that running a "remove duplicates" will return new duplicates. The cases to avoid repeating an existing name would probably be too heavy on the existing code, and a process that checks for duplicates and reruns the generation would probably slow down the tool by having to loop multiple times.
A recommendation for the time being would be to have the identifiers being a concatenation of the ID column and the Name column, that way will completely ensure no duplicates on the output. By this, meaning to adjust the process of the importer itself to simply create an index column that consists of "Name of feature + ID"

from fantasy-map-generator.

Azgaar avatar Azgaar commented on June 11, 2024

Well, I can definitely remove the duplicated, but not sure that it's a common request and a lot of people need it. Generally you can just change your approach and add an index to the names to make them unique, so it should not be a problem. Also you can just ask AI to remove the duplicated for you or create a script to remove them.

from fantasy-map-generator.

Azgaar avatar Azgaar commented on June 11, 2024

Please let me know if you have issues with that, I can probably help

from fantasy-map-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.