Issue:

Module does not work with the latest version (azerothcore/azerothcore-wotlk@911e8b4) and crashes server with this assertion message

Exception code: C0000420 An assertion failure has occurred.

Assertion message: 
C:\AzerothCore\src\server\game\Entities\Pet\Pet.cpp:549 in Pet::SavePetToDB ASSERTION FAILED:
  owner->GetPetStable()->CurrentPet && owner->GetPetStable()->CurrentPet->PetNumber == m_charmInfo->GetPetNumber()

Steps To Reproduce:
( 0. If don't have the beastmaster npc already, add it to world with .npc add 601026 )

1. Make a new Orc Hunter character.
2. Use .character level 10 to make it level 10.
3. Talk to the beastmaster npc and acquire any pet.
4. Crash

Title basically, it makes the pets impossible to die at any level, is there any possible way to nerf this?

Good day to you!
Please update and add a setting to the module, which is responsible for the rate of pet talents (which they get when they level up), as is done in TrinityCore similar module.

I'm not demanding anything, just asking that if there is a sudden update, if possible implement these little features in the module and config. Thank you for your attention and all the best to you!

you can close the problem. it is related to the taming of animals module for all classes

a death knight tames a pet and fashion, and if you click on the spell summon a pet, a death knight pet will appear, not the one you tamed, and the server will crash

this happens not only with the death knight but also with other classes

azerothcore/azerothcore-wotlk#15248

commit Beastmaster: e78d924
commit Azerothcore: azerothcore/azerothcore-wotlk@842ac4c
OS: Ubuntu 16.04

There's no icon indicating the pet's happiness for non-hunters, so it is very hard to know when to feed the pet. Is there perhaps an alternative?

I was debugging this bool Guardian::InitStatsForLevel in core Pet.cpp
and when I select a pet from this module's beastmaster, the code from Guardian::InitStatsForLevel is ran twice in a row.

However if I use .npc tame to tame a beast, then it is only run once (which is the correct behavior obviously). Seems like there is a minor problem here

commit Beastmaster: e78d924
commit Azerothcore: azerothcore/azerothcore-wotlk@842ac4c
OS: Ubuntu 16.04

On some classes the pet does not appear after dismounting. Seems to be only for classes which cannot otherwise have pets (Tested with priest and paladin). "Call Pet" works, but an error message is written to the server log, e.g.:
ERROR: Unknown type pet 24128 is summoned by player class 2

On a mage there's no error message and the pet appears correctly after dismounting.

Need an option to disable the module in the conf

can be a huge time saver when debugging

error message from compiling:

/azerothcore/modules/mod-npc-beastmaster/src/npc_beastmaster.cpp:306:65: fatal error: no member named 'getFaction' in 'Player'
        pet->SetUInt32Value(UNIT_FIELD_FACTIONTEMPLATE, player->getFaction());
                                                        ~~~~~~  ^
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:8749: src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-npc-beastmaster/src/npc_beastmaster.cpp.o] Error 1

When summoning a pet with another class than hunter, I get this:

Unknown type pet 17447 is summoned by player class 4

i suppose it's because I didn't apply the core patch, right?

Note: this issue will be there for reference because I'm pretty sure the answer is to apply the patch

azerothcore/azerothcore-wotlk#3053

I use it with:

BeastMaster.HunterOnly = 1

This is a critical issue.

How to localize the language of the conversation

warning: 'GetBoolDefault' is deprecated: Use GetOption instead [-Wdeprecated-declarations]
BeastMasterAnnounceToPlayer = sConfigMgr->GetBoolDefault("BeastMaster.Announce", true);
Config.h:57:7: note: 'GetBoolDefault' has been explicitly marked deprecated here
[[deprecated("Use GetOption instead")]]
warning: 'GetBoolDefault' is deprecated: Use GetOption instead [-Wdeprecated-declarations]
BeastMasterHunterOnly = sConfigMgr->GetBoolDefault("BeastMaster.HunterOnly", true);

commit Beastmaster: e78d924
commit Azerothcore: azerothcore/azerothcore-wotlk@842ac4c
OS: Ubuntu 16.04

The configuration file cannot be read because the path is missing. I fixed this on my fork (amongst other things):
https://github.com/Stoabrogga/mod-npcbeastmaster